Chartifact popup #200
Merged
Chartifact popup #200
+353
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n and CSS styling (#1) * Initial plan * Initial exploration - understanding report types structure Co-authored-by: danmarshall <11507384+danmarshall@users.noreply.github.com> * Add Chartifact report type with large dialog box Co-authored-by: danmarshall <11507384+danmarshall@users.noreply.github.com> * Refactor Chartifact: Move to separate dialog, add Create button, remove from report types Co-authored-by: danmarshall <11507384+danmarshall@users.noreply.github.com> * Remove package-lock.json from tracking Co-authored-by: danmarshall <11507384+danmarshall@users.noreply.github.com> * Revert .gitignore changes - remove package-lock.json entry Co-authored-by: danmarshall <11507384+danmarshall@users.noreply.github.com> * add example chartifacts * Add Chartifact markdown conversion function with CSV export utility Co-authored-by: danmarshall <11507384+danmarshall@users.noreply.github.com> * Revert yarn.lock to prevent lock file modifications Co-authored-by: danmarshall <11507384+danmarshall@users.noreply.github.com> * Fix image regex pattern to match [IMAGE(chart-id)] format Co-authored-by: danmarshall <11507384+danmarshall@users.noreply.github.com> * Enhance ChartifactDialog to load Chartifact scripts and initialize sandbox * Refactor ChartifactDialog to improve sandbox initialization and state management * Refactor Chartifact markdown conversion to separate spec and CSV replacements, enhance dialog layout, and improve styling * Refactor ChartifactDialog to improve type declarations, enhance sandbox handling, and clean up unused code * Enhance ChartifactDialog to add AI-generated content footer and improve download options for Markdown and HTML reports * Destroy existing sandbox before creating a new one in ChartifactDialog * Add CSS styling based on report type to Chartifact output Co-authored-by: danmarshall <11507384+danmarshall@users.noreply.github.com> * tweak styles * delete sample chartifacts * Add Create Chartifact button with icon in ReportView --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: danmarshall <11507384+danmarshall@users.noreply.github.com> Co-authored-by: Dan Marshall <danmar@microsoft.com>
… tables, and conceptShelfItems parameters for improved markdown conversion
…openChartifactViewer functions; remove ChartifactDialog component usage in ReportView
Collaborator
|
Btw, I think you should open it in chartartifact with markdown panel open already for people to start editing side by side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opens a report as a Chartifact in a new tab instead of an in-app dialog:
Chartifact.pop.from.Data.Formulator.mp4