Conversation
- Refactor data loading to utilize Superset's Chart Data API instead of SQL Lab API, simplifying permission requirements to only `datasource access`. - Enhance documentation to clarify permission needs and security advantages of the new approach. - Update related tests to validate the new data retrieval method and ensure compatibility with the Chart Data API. - Remove obsolete SQL Lab related code and helper functions.
…ized errors - Introduce `extractErrorMessage` function to handle various error types, including RTK serialized errors, ensuring proper message extraction. - Update error handling in `DataSourceSidebar`, `DataThread`, and `DBTableManager` components to utilize the new extraction method, preventing `[object Object]` outputs. - Add tests for `extractErrorMessage` to validate behavior with different error shapes, including ApiRequestError and plain Error instances. - Refactor existing error handling logic to improve clarity and maintainability.
zhb-ai
added a commit
that referenced
this pull request
May 9, 2026
Merge pull request #334 from microsoft/feature/plugin-architecture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.