This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Modified SDK for Quickstart Playground - Chat Style #3908
Closed
Modified SDK for Quickstart Playground - Chat Style #3908
Conversation
manodasanW
reviewed
Sep 28, 2024
extensionsdk/Microsoft.Windows.DevHome.SDK/Microsoft.Windows.DevHome.SDK.idl
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Sep 28, 2024
extensionsdk/Microsoft.Windows.DevHome.SDK/Microsoft.Windows.DevHome.SDK.idl
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Sep 28, 2024
extensionsdk/Microsoft.Windows.DevHome.SDK/Microsoft.Windows.DevHome.SDK.idl
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Sep 28, 2024
extensionsdk/Microsoft.Windows.DevHome.SDK/Microsoft.Windows.DevHome.SDK.idl
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Sep 28, 2024
| [experimental] | ||
| [contract(Microsoft.Windows.DevHome.SDK.DevHomeContract, 6)] | ||
| runtimeclass QuickStartChatStyleResult | ||
| { |
Member
There was a problem hiding this comment.
Do we think we want a class to provide flexibility for the chat result for the future rather than just using string below in the async operation?
This was referenced Sep 30, 2024
dhoehna
reviewed
Oct 1, 2024
extensionsdk/Microsoft.Windows.DevHome.SDK/Microsoft.Windows.DevHome.SDK.idl
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Oct 1, 2024
extensionsdk/Microsoft.Windows.DevHome.SDK/Microsoft.Windows.DevHome.SDK.idl
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Oct 1, 2024
extensionsdk/Microsoft.Windows.DevHome.SDK/Microsoft.Windows.DevHome.SDK.idl
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Oct 1, 2024
extensionsdk/Microsoft.Windows.DevHome.SDK/Microsoft.Windows.DevHome.SDK.idl
Outdated
Show resolved
Hide resolved
Contributor
|
Do you have a link to the API review? |
Contributor
Author
Good question! It is in the works. I had just sent mail out to Hart about this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Introduces SDK changes needed for the Chat Style integration of Quickstart Playground
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist