Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Returning exception message for more general exceptions. #386

Merged
dhoehna merged 2 commits into from
Apr 26, 2024
Merged

Returning exception message for more general exceptions. #386

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07be286
Adding 'Please check the logs'
dhoehna Apr 24, 2024
84f7997
SHowing the error on the loading screen
dhoehna Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/GitHubExtension/Providers/RepositoryProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,12 +267,12 @@ public IAsyncOperation<ProviderOperationResult> CloneRepositoryAsync(IRepository
catch (LibGit2Sharp.LibGit2SharpException libGitTwoException)
{
Log.Error(libGitTwoException, $"Either no logged in account has access to this repository, or the repository can't be found.");
return new ProviderOperationResult(ProviderOperationStatus.Failure, libGitTwoException, "LibGit2 library threw an exception.", "LibGit2 library threw an exception.");
return new ProviderOperationResult(ProviderOperationStatus.Failure, libGitTwoException, libGitTwoException.Message, libGitTwoException.Message);
}
catch (Exception e)
{
Log.Error(e, "Could not clone the repository.");
return new ProviderOperationResult(ProviderOperationStatus.Failure, e, "Something happened when cloning the repository.", "Something happened when cloning the repository.");
return new ProviderOperationResult(ProviderOperationStatus.Failure, e, e.Message, e.Message);
}

return new ProviderOperationResult(ProviderOperationStatus.Success, new ArgumentException("Nothing wrong"), "Nothing wrong", "Nothing wrong");
Expand Down