Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions build/azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ parameters:
- release

variables:
MSIXVersion: '0.1300'
MSIXVersion: '0.1400'
solution: '**/GitHubExtension.sln'
appxPackageDir: 'AppxPackages'
testOutputArtifactDir: 'TestResults'
Expand Down Expand Up @@ -83,13 +83,13 @@ extends:
nugetConfigPath: 'nuget.config'
externalFeedCredentials: 'DevHomeInternal'

- task: MicrosoftTDBuild.tdbuild-task.tdbuild-task.TouchdownBuildTask@1
- task: MicrosoftTDBuild.tdbuild-task.tdbuild-task.TouchdownBuildTask@3
displayName: Send and Download Localization Files for Artifacts
condition: and(eq(variables['EnableLocalization'], 'true'), eq(variables['UpdateLocalization'], 'true'))
inputs:
teamId: 71221
authId: $(TouchdownAppId)
authKey: $(TouchdownAppKey)
TDBuildServiceConnection: $(TouchdownServiceConnection)
authType: SubjectNameIssuer
resourceFilePath: |
**\en-US\*.resw;P:466
**\en-US\PDP.xml
Expand All @@ -98,14 +98,14 @@ extends:
appendRelativeDir: true
pseudoSetting: Included

- task: MicrosoftTDBuild.tdbuild-task.tdbuild-task.TouchdownBuildTask@1
- task: MicrosoftTDBuild.tdbuild-task.tdbuild-task.TouchdownBuildTask@3
displayName: Download and Use Localization Files
condition: eq(variables['EnableLocalization'], 'true')
retryCountOnTaskFailure: 2
inputs:
teamId: 71221
authId: $(TouchdownAppId)
authKey: $(TouchdownAppKey)
TDBuildServiceConnection: $(TouchdownServiceConnection)
authType: SubjectNameIssuer
resourceFilePath: |
**\en-US\*.resw;P:466
**\en-US\PDP.xml
Expand Down Expand Up @@ -365,14 +365,14 @@ extends:
artifactName: MsixBundle_Release
targetPath: StorePublish

- task: MicrosoftTDBuild.tdbuild-task.tdbuild-task.TouchdownBuildTask@1
- task: MicrosoftTDBuild.tdbuild-task.tdbuild-task.TouchdownBuildTask@3
displayName: Download and Use Localization Files
condition: eq(variables['EnableLocalization'], 'true')
retryCountOnTaskFailure: 2
inputs:
teamId: 71221
authId: $(TouchdownAppId)
authKey: $(TouchdownAppKey)
TDBuildServiceConnection: $(TouchdownServiceConnection)
authType: SubjectNameIssuer
resourceFilePath: |
**\en-US\PDP.xml
localizationTarget: false
Expand Down
2 changes: 1 addition & 1 deletion build/scripts/CreateBuildInfo.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Param(
)

$Major = "0"
$Minor = "13"
$Minor = "14"
$Patch = "99" # default to 99 for local builds

$versionSplit = $Version.Split(".");
Expand Down
5 changes: 3 additions & 2 deletions src/GitHubExtension/Providers/RepositoryProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ public IAsyncOperation<ProviderOperationResult> CloneRepositoryAsync(IRepository
var cloneOptions = new LibGit2Sharp.CloneOptions
{
Checkout = true,
RecurseSubmodules = true,
};

if (developerId != null)
Expand Down Expand Up @@ -267,12 +268,12 @@ public IAsyncOperation<ProviderOperationResult> CloneRepositoryAsync(IRepository
catch (LibGit2Sharp.LibGit2SharpException libGitTwoException)
{
Log.Error(libGitTwoException, $"Either no logged in account has access to this repository, or the repository can't be found.");
return new ProviderOperationResult(ProviderOperationStatus.Failure, libGitTwoException, "LibGit2 library threw an exception.", "LibGit2 library threw an exception.");
return new ProviderOperationResult(ProviderOperationStatus.Failure, libGitTwoException, libGitTwoException.Message, libGitTwoException.Message);
}
catch (Exception e)
{
Log.Error(e, "Could not clone the repository.");
return new ProviderOperationResult(ProviderOperationStatus.Failure, e, "Something happened when cloning the repository.", "Something happened when cloning the repository.");
return new ProviderOperationResult(ProviderOperationStatus.Failure, e, e.Message, e.Message);
}

return new ProviderOperationResult(ProviderOperationStatus.Success, new ArgumentException("Nothing wrong"), "Nothing wrong", "Nothing wrong");
Expand Down
2 changes: 2 additions & 0 deletions src/GitHubExtension/Widgets/GitHubWidget.cs
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ public override void OnActionInvoked(WidgetActionInvokedArgs actionInvokedArgs)
// It might take some time to get the new data, so
// set data state to "unknown" so that loading page is shown.
DataState = WidgetDataState.Unknown;

ConfigurationData = actionInvokedArgs.Data;
UpdateWidget();

SavedConfigurationData = string.Empty;
Expand Down