Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Fix duplicate classIDs for different builds#418

Merged
EricJohnson327 merged 2 commits intomainfrom
user/ejohn/classIDs
Jul 23, 2024
Merged

Fix duplicate classIDs for different builds#418
EricJohnson327 merged 2 commits intomainfrom
user/ejohn/classIDs

Conversation

@EricJohnson327
Copy link
Contributor

Summary of the pull request

Stable/Canary/Dev builds all use the same ClassIds in package.appxmanifest. This causes issues when multiple versions are installed at the same time, notably not being able to determine which version will actually get activated. This change clones package.appxmanifest into three different versions and changes the ClassIds for Canary/Dev versions (Stable remains the same).

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@krschau krschau added this to the DHGE v0.17 milestone Jul 23, 2024
Copy link

@zadesai zadesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@EricJohnson327 EricJohnson327 merged commit 276e9c4 into main Jul 23, 2024
@EricJohnson327 EricJohnson327 deleted the user/ejohn/classIDs branch July 23, 2024 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

4 participants