Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Add HttpRequestException expected exception handling#443

Merged
dkbennett merged 1 commit intomainfrom
user/dkbennett/httprequestexception
Sep 11, 2024
Merged

Add HttpRequestException expected exception handling#443
dkbennett merged 1 commit intomainfrom
user/dkbennett/httprequestexception

Conversation

@dkbennett
Copy link
Member

@dkbennett dkbennett commented Sep 6, 2024

Summary of the pull request

Adds exception handling to not spam detailed error stack when we have an HttpRequest exception. This keeps the log clean and avoids giving us false alarm exception spam when unrelated network issues happen, such as DNS resolution problems or simply no internet connection.

References and relevant issues

Observed such false alarm spam in: microsoft/devhome#3778

Detailed description of the pull request / Additional comments

  • Adds exception catches specifically for HttpRequestException and treats them as warnings and does not log the exception.

Validation steps performed

  • Built and deployed fix with forced HttpRequestException thrown to verify handling. Confirmed log has warnings and no exception stack dump and no errors.

PR checklist

@dkbennett dkbennett merged commit 8664939 into main Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expected Http errors are noisy in the log and sending false positives of issues

4 participants