Migrate github-release pipeline to 1ES governed template#178
Migrate github-release pipeline to 1ES governed template#178shishirb-MSFT merged 19 commits intodevelopfrom
Conversation
| imageVersion: ${{parameters.imageVersion}} | ||
| config: debug | ||
| - publish: $(Build.ArtifactStagingDirectory) | ||
| artifact: 'doclient-drop-${{parameters.targetOsArch}}-debug' |
There was a problem hiding this comment.
Yes. The 1ES tasks also publish artifacts/drop, so I'm making ours distinguishable.
There was a problem hiding this comment.
I see. What is different from the artifacts that the 1ES task produces and ours?
There was a problem hiding this comment.
There was a problem hiding this comment.
thank you, that helps. The doclient convention makes sense; wasn't too sure about the "drop", but I guess its consistent.
| TargetFolder: '$(Build.ArtifactStagingDirectory)/agent-${{parameters.targetOsArch}}-${{parameters.config}}' | ||
| displayName: 'Populate debug symbols to staging dir' | ||
|
|
||
| - task: PublishBuildArtifacts@1 |
There was a problem hiding this comment.
Yes. And the same part in release-docker-build-steps.yml as well.
It was the migration tool that moved these lines from here the parent yaml, so I kept it that way.
| changeLogCompareToRelease: 'lastNonDraftReleaseByTag' | ||
| changeLogCompareToReleaseTag: '$(Release.PreviousVersion)' | ||
| changeLogType: 'commitBased' | ||
| - name: SkipPublishing |
There was a problem hiding this comment.
We are currently attempting to create that as its own separate pipeline (release pipeline) but hitting some issues. We'll know more next week.
If we decide to do it in this pipeline, then yes we will integrate it after the GithubRelease task at the bottom.
|
@shiyi-peng is added to the review. #Closed |
| # Example: | ||
| # docker run -ti --rm --entrypoint=/bin/bash -v D:\do-client-lite:/code -v D:\temp\build_client_lite\linux-debug:/build ubuntu1804-x64 | ||
|
|
||
| FROM mcr.microsoft.com/mirror/docker/library/ubuntu:18.04@sha256:152dc042452c496007f07ca9127571cb9c29697f42acbfad72324b2bb2e43c98 |
2 participants
No description provided.