refactor: Changed Async and Sync Azure credential retrieval #526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request refactors the codebase to consistently use the asynchronous version of the
get_azure_credentialfunction (get_azure_credential_async) across multiple modules. This change ensures compatibility with asynchronous workflows and improves consistency in how Azure credentials are retrieved.Updates to Azure credential handling:
get_azure_credentialwithget_azure_credential_asyncin theAIProjectClientinitialization withinasync def init_ai_foundry_client()insrc/app.py.get_azure_credentialfromget_azure_credential_asyncinasync def fetch_azure_search_content()insrc/app.py, likely due to specific synchronous requirements in that context.Updates to agent factories:
src/backend/api/agent/browse_agent_factory.py,src/backend/api/agent/section_agent_factory.py, andsrc/backend/api/agent/template_agent_factory.pyto useget_azure_credential_async. [1] [2] [3]async def create_or_get_agent(cls)method in all three agent factory modules to useawait get_azure_credential_async()for initializingAIProjectClient. [1] [2] [3]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information