Skip to content

Conversation

@NirajC-Microsoft
Copy link
Contributor

Purpose

This pull request makes minor improvements to deployment configuration and infrastructure parameter handling. The changes mainly focus on improving robustness and cleaning up unnecessary parameters.

Infrastructure parameter handling:

  • Updated the createdBy parameter in infra/main.bicep to handle cases where userPrincipalName may not be present in the deployer object, defaulting to objectId if necessary.

Deployment configuration:

  • Removed the unused createdBy environment variable from the deployment step in .github/workflows/deploy.yml for cleaner configuration.
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 62b6009 into dev Sep 23, 2025
4 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the psl-Pipelinefix branch September 23, 2025 10:17
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants