Skip to content

Switch netfx sample to sdk style csproj#49

Merged
jviau merged 2 commits intomicrosoft:mainfrom
jviau:netfx-sample-sdk
Sep 27, 2022
Merged

Switch netfx sample to sdk style csproj#49
jviau merged 2 commits intomicrosoft:mainfrom
jviau:netfx-sample-sdk

Conversation

@jviau
Copy link
Member

@jviau jviau commented Sep 27, 2022

No description provided.

@jviau jviau requested a review from cgillum September 27, 2022 05:23
@jviau
Copy link
Member Author

jviau commented Sep 27, 2022

@cgillum is it okay to switch this project to net48 as well?

@cgillum
Copy link
Member

cgillum commented Sep 27, 2022

@cgillum is it okay to switch this project to net48 as well?

That’s fine by me, but any particular reason?

@jviau
Copy link
Member Author

jviau commented Sep 27, 2022

That’s fine by me, but any particular reason?

Mostly for convenience. I think having net48 installed will be more common that other versions. For example, installing Visual Studio and selecting net framework will install 48. To get other versions you need to explicitly select them from the individual components section.

@cgillum
Copy link
Member

cgillum commented Sep 27, 2022

For example, installing Visual Studio and selecting net framework will install 48. To get other versions you need to explicitly select them from the individual components section.

That sounds like a good reason to me. Let's do it!

@jviau jviau merged commit 52af906 into microsoft:main Sep 27, 2022
@jviau jviau deleted the netfx-sample-sdk branch September 27, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants