Extract DurableTask.Core shims to common Worker package#55
Extract DurableTask.Core shims to common Worker package#55jviau merged 3 commits intomicrosoft:mainfrom
Conversation
| object? input = this.invocationContext.DataConverter.Deserialize(rawInput, this.implementation.InputType); | ||
|
|
||
| this.wrapperContext = new(innerContext, this.name, this.workerContext, this.runtimeState, input); | ||
| ILogger contextLogger = this.invocationContext.LoggerFactory.CreateLogger("Microsoft.DurableTask"); |
There was a problem hiding this comment.
Previously we encapsulated the creation of loggers inside SdkUtils.GetLogger(loggerFactory). Is there a reason to not do that here?
There was a problem hiding this comment.
Don't have SdkUtils here. I also plan on refactoring that later. We should not be using a single category, but rather multiple categories. We just have to make sure they all start with Microsoft.DurableTask. So this one I actually want to change to .CreateLogger<TaskOrchestrationContext>() (in another PR).
By using multiple categories we will allow for more granular log filtering - if customer so decides. But they can still filter on "Microsoft.DurableTask" to cover all of them.
cgillum
left a comment
cgillum
left a comment
There was a problem hiding this comment.
Just one minor comment note, but otherwise LGTM! It's really nice to see the structure of the project take a more mature shape like this.
2 participants
This PR extracts the shims to
Microsoft.DurableTask.Workerand allows for public usage of them viaDurableTaskShimFactoryabstraction. This change also involved some other refactors:FuncTaskOrchestratorto worker package (from abstractions).OrchestrationRunnertoGrpcOrchestrationRunner(as it is gRPC specific).