Remove setting of TaskName.Version for now#71
Merged
jviau merged 1 commit intomicrosoft:mainfrom Oct 25, 2022
Merged
Conversation
cgillum
approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the fact we do not consider
TaskName.Versionas part of equality checks, it is effectively unusable to customers. You cannot register two tasks with the same name, but different versions. Additionally incoming work requests of the same name will always resolve to the same instance regardless of version matching. I am opting to remove the ability to set this for now as it is misleading to customers. We can add it back in when task versioning is actually supported.