Skip to content

Update sign task, snupkg symbols, readme.md#87

Merged
jviau merged 3 commits intomicrosoft:mainfrom
jviau:release-build
Nov 19, 2022
Merged

Update sign task, snupkg symbols, readme.md#87
jviau merged 3 commits intomicrosoft:mainfrom
jviau:release-build

Conversation

@jviau
Copy link
Member

@jviau jviau commented Nov 18, 2022

  1. Fixes the path for the sign task src --> out/bin
  2. Switches debug symbols from embedded to be delivered via snupkg.
    • This reduces the size of our nupkgs, and lets debuggers download the pdb's separately only when needed (this happens automatically for the user via NuGet and snupkg's)
  3. Update readme.md with the recent API changes, also removed the feature parity callout as we are still addressing that aspect.
  4. Moved InternalsVisibleTo.cs to be generated earlier in build to address source link issue.

@jviau jviau requested a review from cgillum November 18, 2022 19:14
<PackageProjectUrl>$(RepositoryUrl)</PackageProjectUrl>
<PackageReleaseNotes>$(RepositoryUrl)/releases/</PackageReleaseNotes>
<PackageTags>Microsoft Durable Task Orchestration Workflow Activity Reliable DTFx</PackageTags>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never dealt with snupkg's. How do they get published?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as a nupkg - nuget push *.snupkg

@jviau jviau merged commit 33bbe4b into microsoft:main Nov 19, 2022
@jviau jviau deleted the release-build branch November 19, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants