Skip to content

Conversation

@bachuv
Copy link
Contributor

@bachuv bachuv commented Jan 29, 2026

Issue describing the changes in this PR

This PR adds workflow_dispatch: to build-validation.yml so we can trigger workflows manually from branches and we don't have to open PRs to run the workflow. This will help us debug CI issues without having to open PRs.

It also updates 2 flaky tests:

  • longTimeStampTimer : now disabled. Timing variations in the CI can cause the timer to chunk into 4 or 5 replays instead of exactly 4, making the exact count assertion flaky. The similar longTimer has been disabled since June.
  • externalEventsWithTimeouts : increased the timeout from 3 to 10 seconds.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

@bachuv bachuv requested a review from a team as a code owner January 29, 2026 00:23
Copilot AI review requested due to automatic review settings January 29, 2026 00:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables manual triggering of the existing build validation GitHub Actions workflow to facilitate debugging CI issues without opening PRs.

Changes:

  • Added workflow_dispatch to the workflow triggers in .github/workflows/build-validation.yml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

andystaples
andystaples previously approved these changes Jan 29, 2026
@bachuv bachuv changed the title Add support for running workflows manually Add support for running GitHub workflows manually Jan 29, 2026
@bachuv bachuv changed the title Add support for running GitHub workflows manually Add support for running GitHub workflows manually and update flaky tests Jan 29, 2026
@bachuv bachuv merged commit ecc0124 into main Jan 29, 2026
8 checks passed
@bachuv bachuv deleted the vabachu/manual-workflow branch January 29, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants