Fix exception handling and stale trace context in distributed tracing#267
Merged
torosent merged 3 commits intofeature/distributed-tracing-otelfrom Mar 3, 2026
Merged
Conversation
4 tasks
Co-authored-by: torosent <17064840+torosent@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add distributed tracing support with OpenTelemetry
Fix exception handling and stale trace context in distributed tracing
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three correctness issues in the distributed tracing implementation identified during review.
Changes
DurableTaskGrpcWorker.java: Replacecatch (Throwable e) { throw e; }with explicitErrorrethrow +RuntimeExceptionwrap — preservesErrortype identity and avoids ambiguous re-throw semantics.TaskOrchestrationExecutor.java: Explicitly setparentTraceContext = nullwhenExecutionStartedEventhas no parent trace context. Previously, a stale context from a prior execution could leak into activities/sub-orchestrations during continue-as-new or replay.OrchestrationRunner.java: Narrow catch fromThrowabletoException(prevents wrappingErrors likeOutOfMemoryError); moveorchestrationScope.close()tofinallyto guarantee cleanup.Pull request checklist
CHANGELOG.md💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.