Skip to content

Update code review agent instructions#119

Merged
YunchuWang merged 2 commits intomainfrom
wangbill/en
Mar 2, 2026
Merged

Update code review agent instructions#119
YunchuWang merged 2 commits intomainfrom
wangbill/en

Conversation

@YunchuWang
Copy link
Member

Summary

What changed?

Why is this change needed?

Issues / work items

  • Resolves #
  • Related #

Project checklist

  • Release notes are not required for the next release
    • Otherwise: Notes added to CHANGELOG.md
  • Backport is not required
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • All required tests have been added/updated (unit tests, E2E tests)
  • Breaking change?
    • If yes:
      • Impact:
      • Migration guidance:

AI-assisted code disclosure (required)

Was an AI tool used? (select one)

  • No
  • Yes, AI helped write parts of this PR (e.g., GitHub Copilot)
  • Yes, an AI agent generated most of this PR

If AI was used:

  • Tool(s):
  • AI-assisted areas/files:
  • What you changed after AI output:

AI verification (required if AI was used):

  • I understand the code and can explain it
  • I verified referenced APIs/types exist and are correct
  • I reviewed edge cases/failure paths (timeouts, retries, cancellation, exceptions)
  • I reviewed concurrency/async behavior
  • I checked for unintended breaking or behavior changes

Testing

Automated tests

  • Result: Passed / Failed (link logs if failed)

Manual validation (only if runtime/behavior changed)

  • Environment (OS, Node.js version, components):
  • Steps + observed results:
    1.
    2.
    3.
  • Evidence (optional):

Notes for reviewers

  • N/A

Copilot AI review requested due to automatic review settings March 2, 2026 23:28
@YunchuWang YunchuWang changed the title Wangbill/en Update code review agent instructions Mar 2, 2026
@YunchuWang YunchuWang merged commit a629b19 into main Mar 2, 2026
18 checks passed
@YunchuWang YunchuWang deleted the wangbill/en branch March 2, 2026 23:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the daily-code-review GitHub Copilot agent instructions to reflect that deduplication context is pre-loaded by the workflow and to strengthen test expectations (unit tests plus Azure Managed E2E tests for runtime behavior changes).

Changes:

  • Replaces the “deduplication steps” section with a “review exclusion list” section that assumes pre-injected PR/issue context.
  • Tightens PR guidance to require unit tests for fixes/improvements.
  • Adds guidance to also add Azure Managed E2E tests under test/e2e-azuremanaged/ when changing orchestration/activity/entity/client/worker behavior.

Comment on lines +137 to +138
`DurableTaskAzureManagedWorkerBuilder`, reads `DTS_CONNECTION_STRING` or
`ENDPOINT`/`TASKHUB` env vars). Add the new test case to the appropriate existing
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The env var guidance here doesn’t match the existing test/e2e-azuremanaged patterns. Several specs use DURABLE_TASK_SCHEDULER_CONNECTION_STRING (e.g., query-apis.spec.ts, rewind.spec.ts) and entity.spec.ts uses AZURE_DTS_CONNECTION_STRING, so stating it “reads DTS_CONNECTION_STRING” is misleading. Please update this wording to reflect the actual accepted env vars (or standardize the e2e tests and then document the standardized names).

Suggested change
`DurableTaskAzureManagedWorkerBuilder`, reads `DTS_CONNECTION_STRING` or
`ENDPOINT`/`TASKHUB` env vars). Add the new test case to the appropriate existing
`DurableTaskAzureManagedWorkerBuilder`, and reads the same supported env vars as
the existing specs, such as `DURABLE_TASK_SCHEDULER_CONNECTION_STRING` or
`AZURE_DTS_CONNECTION_STRING`). Add the new test case to the appropriate existing

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants