Conversation
There was a problem hiding this comment.
Pull request overview
Updates the daily-code-review GitHub Copilot agent instructions to reflect that deduplication context is pre-loaded by the workflow and to strengthen test expectations (unit tests plus Azure Managed E2E tests for runtime behavior changes).
Changes:
- Replaces the “deduplication steps” section with a “review exclusion list” section that assumes pre-injected PR/issue context.
- Tightens PR guidance to require unit tests for fixes/improvements.
- Adds guidance to also add Azure Managed E2E tests under
test/e2e-azuremanaged/when changing orchestration/activity/entity/client/worker behavior.
| `DurableTaskAzureManagedWorkerBuilder`, reads `DTS_CONNECTION_STRING` or | ||
| `ENDPOINT`/`TASKHUB` env vars). Add the new test case to the appropriate existing |
There was a problem hiding this comment.
The env var guidance here doesn’t match the existing test/e2e-azuremanaged patterns. Several specs use DURABLE_TASK_SCHEDULER_CONNECTION_STRING (e.g., query-apis.spec.ts, rewind.spec.ts) and entity.spec.ts uses AZURE_DTS_CONNECTION_STRING, so stating it “reads DTS_CONNECTION_STRING” is misleading. Please update this wording to reflect the actual accepted env vars (or standardize the e2e tests and then document the standardized names).
| `DurableTaskAzureManagedWorkerBuilder`, reads `DTS_CONNECTION_STRING` or | |
| `ENDPOINT`/`TASKHUB` env vars). Add the new test case to the appropriate existing | |
| `DurableTaskAzureManagedWorkerBuilder`, and reads the same supported env vars as | |
| the existing specs, such as `DURABLE_TASK_SCHEDULER_CONNECTION_STRING` or | |
| `AZURE_DTS_CONNECTION_STRING`). Add the new test case to the appropriate existing |
Summary
What changed?
Why is this change needed?
Issues / work items
Project checklist
CHANGELOG.mdAI-assisted code disclosure (required)
Was an AI tool used? (select one)
If AI was used:
AI verification (required if AI was used):
Testing
Automated tests
Manual validation (only if runtime/behavior changed)
1.
2.
3.
Notes for reviewers