Skip to content

Enforce Azure Managed e2e tests in daily-code-review agent#139

Merged
YunchuWang merged 1 commit intomainfrom
wangbill/enforce-azuremanaged-e2e-in-agent
Mar 5, 2026
Merged

Enforce Azure Managed e2e tests in daily-code-review agent#139
YunchuWang merged 1 commit intomainfrom
wangbill/enforce-azuremanaged-e2e-in-agent

Conversation

@YunchuWang
Copy link
Member

Make the requirement for Azure Managed e2e tests explicit and mandatory when behavioral changes are made. The agent was frequently skipping these tests. Changes:

  • Mark Azure Managed e2e tests as MANDATORY (not just suggested)
  • Add quality gate step to verify e2e tests were included
  • Require justification in PR body if e2e tests are not feasible

Summary

What changed?

Why is this change needed?

Issues / work items

  • Resolves #
  • Related #

Project checklist

  • Release notes are not required for the next release
    • Otherwise: Notes added to CHANGELOG.md
  • Backport is not required
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • All required tests have been added/updated (unit tests, E2E tests)
  • Breaking change?
    • If yes:
      • Impact:
      • Migration guidance:

AI-assisted code disclosure (required)

Was an AI tool used? (select one)

  • No
  • Yes, AI helped write parts of this PR (e.g., GitHub Copilot)
  • Yes, an AI agent generated most of this PR

If AI was used:

  • Tool(s):
  • AI-assisted areas/files:
  • What you changed after AI output:

AI verification (required if AI was used):

  • I understand the code and can explain it
  • I verified referenced APIs/types exist and are correct
  • I reviewed edge cases/failure paths (timeouts, retries, cancellation, exceptions)
  • I reviewed concurrency/async behavior
  • I checked for unintended breaking or behavior changes

Testing

Automated tests

  • Result: Passed / Failed (link logs if failed)

Manual validation (only if runtime/behavior changed)

  • Environment (OS, Node.js version, components):
  • Steps + observed results:
    1.
    2.
    3.
  • Evidence (optional):

Notes for reviewers

  • N/A

Make the requirement for Azure Managed e2e tests explicit and mandatory
when behavioral changes are made. The agent was frequently skipping these
tests. Changes:

- Mark Azure Managed e2e tests as MANDATORY (not just suggested)
- Add quality gate step to verify e2e tests were included
- Require justification in PR body if e2e tests are not feasible

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 5, 2026 22:06
@YunchuWang YunchuWang merged commit 9bdc0b2 into main Mar 5, 2026
14 checks passed
@YunchuWang YunchuWang deleted the wangbill/enforce-azuremanaged-e2e-in-agent branch March 5, 2026 22:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Makes Azure Managed end-to-end testing a hard requirement for behavior changes in the daily code review agent guidance, adding an explicit quality gate and requiring PR justification when e2e tests can’t be added.

Changes:

  • Promoted Azure Managed e2e tests from “suggested” to “MANDATORY” for behavioral changes.
  • Added a pre-PR quality gate checklist step to verify Azure Managed e2e tests were included when applicable.
  • Required explicit justification in the PR body when Azure Managed e2e tests are not feasible.
Comments suppressed due to low confidence (2)

.github/agents/daily-code-review.agent.md:1

  • The new list item appears to have lost the indentation that the previous nested bullet used (the removed version was indented before |-). This likely changes markdown nesting/formatting in the rendered doc. Keep indentation consistent with the surrounding list (e.g., align with the prior |- ... pattern) so it stays part of the same nested test guidance section.
---

.github/agents/daily-code-review.agent.md:1

  • The surrounding text refers to 'tests' (plural) but this sentence mandates adding a single test ('an ... test'). To avoid ambiguity for changes that may require multiple cases, consider wording like 'one or more Azure Managed e2e tests' or 'at least one Azure Managed e2e test'.
---

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants