Enforce Azure Managed e2e tests in daily-code-review agent#139
Merged
YunchuWang merged 1 commit intomainfrom Mar 5, 2026
Merged
Enforce Azure Managed e2e tests in daily-code-review agent#139YunchuWang merged 1 commit intomainfrom
YunchuWang merged 1 commit intomainfrom
Conversation
Make the requirement for Azure Managed e2e tests explicit and mandatory when behavioral changes are made. The agent was frequently skipping these tests. Changes: - Mark Azure Managed e2e tests as MANDATORY (not just suggested) - Add quality gate step to verify e2e tests were included - Require justification in PR body if e2e tests are not feasible Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kaibocai
approved these changes
Mar 5, 2026
There was a problem hiding this comment.
Pull request overview
Makes Azure Managed end-to-end testing a hard requirement for behavior changes in the daily code review agent guidance, adding an explicit quality gate and requiring PR justification when e2e tests can’t be added.
Changes:
- Promoted Azure Managed e2e tests from “suggested” to “MANDATORY” for behavioral changes.
- Added a pre-PR quality gate checklist step to verify Azure Managed e2e tests were included when applicable.
- Required explicit justification in the PR body when Azure Managed e2e tests are not feasible.
Comments suppressed due to low confidence (2)
.github/agents/daily-code-review.agent.md:1
- The new list item appears to have lost the indentation that the previous nested bullet used (the removed version was indented before
|-). This likely changes markdown nesting/formatting in the rendered doc. Keep indentation consistent with the surrounding list (e.g., align with the prior|- ...pattern) so it stays part of the same nested test guidance section.
---
.github/agents/daily-code-review.agent.md:1
- The surrounding text refers to 'tests' (plural) but this sentence mandates adding a single test ('an ... test'). To avoid ambiguity for changes that may require multiple cases, consider wording like 'one or more Azure Managed e2e tests' or 'at least one Azure Managed e2e test'.
---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the requirement for Azure Managed e2e tests explicit and mandatory when behavioral changes are made. The agent was frequently skipping these tests. Changes:
Summary
What changed?
Why is this change needed?
Issues / work items
Project checklist
CHANGELOG.mdAI-assisted code disclosure (required)
Was an AI tool used? (select one)
If AI was used:
AI verification (required if AI was used):
Testing
Automated tests
Manual validation (only if runtime/behavior changed)
1.
2.
3.
Notes for reviewers