test: Add comprehensive unit tests for WhenAnyTask#162
Merged
YunchuWang merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
WhenAnyTask is a core public API (exported via whenAny()) with zero test coverage, despite its sibling WhenAllTask having 7 tests. This adds 11 unit tests covering: - Empty input validation - Basic completion on first child - Result is the completed child Task itself - Child failure behavior (WhenAny does not propagate, returns failed task) - Idempotent completion guard (subsequent completions ignored) - Pre-completed children (immediate completion in constructor) - Pre-failed children - Multiple pre-completed children (first wins) - Single-child edge case - Parent composite task notification - No completion when no children have completed Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing unit test coverage for the core WhenAnyTask composite task, ensuring its completion semantics and key edge-cases are protected against regressions (closes #158).
Changes:
- Introduces a new Jest spec file covering
WhenAnyTaskvalidation, completion, failure-result semantics, idempotency, and pre-completed/pre-failed children. - Adds a regression-style test that validates parent composite notification behavior via
WhenAllTask.
You can also share your feedback on Copilot code review. Take the survey.
kaibocai
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive unit test coverage for WhenAnyTask, which previously had zero tests.
Closes #158
Changes