fix(deps): consolidate vulnerable package remediation#657
Merged
Conversation
Bump checkov to 3.3.6 (root) and numpy/pytest/pytest-asyncio in the ros2-connector, and migrate opentelemetry_sdk 0.29->0.32.1 across the telemetry sender/receiver and mqtt-otel-trace-exporter services. Suppress the transitive ecdsa timing-attack finding (GHSA-wj6h-64fc-37mp, no upstream fix) in .grype.yaml and osv-scanner.toml, and centralize the dependency-review allow-list out of pr-validation.yml into .github/dependency-review-config.yml. Handle the new Result from span.set_parent in the receiver otel setup.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #657 +/- ##
==========================================
- Coverage 31.80% 31.79% -0.02%
==========================================
Files 40 40
Lines 6015 6017 +2
==========================================
Hits 1913 1913
- Misses 4102 4104 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
bindsi
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR folds several outstanding dependency-update PRs into a single, coherent vulnerable-package remediation commit. It moves the Python and Rust dependency stacks forward, centralizes the dependency-review policy, and suppresses one transitive advisory consistently across every security scanner the repository runs.
The work spans three distinct areas: a coordinated OpenTelemetry uplift across the Rust telemetry services, Python dependency bumps for
checkovand the ROS2 connector, and security-scanner configuration changes that consolidate suppression policy into a dedicated config file.Rust OpenTelemetry migration
Migrated the OpenTelemetry family from 0.29.x to 0.32.x across three services —
501-rust-telemetry/services/receiver,501-rust-telemetry/services/sender, and504-mqtt-otel-trace-exporter— with matching pins in each Cargo.toml and regenerated Cargo.lock.opentelemetry0.29.1 → 0.32.0,opentelemetry-http0.29.0 → 0.32.0,opentelemetry-otlp0.29.0 → 0.32.0 (retaininggrpc-tonic),opentelemetry-proto0.29.0 → 0.32.0,opentelemetry_sdk0.29.0 → 0.32.1, andtracing-opentelemetry0.30.0 → 0.33.0.rt-tokiofeature onopentelemetry_sdkin each manifest, reflecting the newer SDK's async-runtime feature reorganization.tonic0.12.3 → 0.14.6,prost/prost-derive0.13.5 → 0.14.4, andreqwest0.12.28 → 0.13.4.portable-atomic1.13.1,prost-types0.14.4,tonic-prost0.14.6,tonic-types0.14.6) and consolidated duplicates by removingindexmap1.9.3 (andhashbrown0.12.3),glob0.3.3,ryu1.0.23, andserde_urlencoded0.7.1, collapsing the dualtowergraph into a single version.span.set_parent(cx)now returns aResult, so the call site logs atracing::warn!on failure rather than assuming success.Python dependency bumps
checkov~=3.2.529→~=3.3.6in requirements.in and regenerated requirements.txt, which addedecdsa0.19.2 (pulled in via checkov) and movedaiohttp3.14.1 → 3.13.5 as a transitive consequence of the new constraint.numpy>=2.4.6→>=2.5.0,pytest9.0.3 → 9.1.1,pytest-asyncio1.3.0 → 1.4.0. The regenerated requirements.base.txt also normalized its# via -rannotations to repo-root-relative paths, indicatingpip-compilewas re-run from the repository root.Security scanner configuration
config-fileinstead of inlinewith:parameters.Related Issue
Fixes #656
Type of Change
Implementation Details
Consolidated multiple dependency PRs into one commit. The OpenTelemetry uplift kept each service's Cargo.toml and Cargo.lock tightly aligned (for example,
opentelemetry_sdkpinned to 0.32.1 in both), and lockfile churn favored graph simplification by eliminating duplicate crate versions rather than introducing behavioral change. The single required source change was theset_parentfallibility adaptation in the receiver.Security suppressions were applied once per scanner (grype, osv-scanner, dependency-review) with identical rationale, and the dependency-review policy was externalized from the workflow YAML into a version-controlled config file to reduce duplication.
Testing Performed
cargo clippy --all-targetsandcargo testrun against the receiver and mqtt-otel-trace-exporter services after the OpenTelemetry updateValidation Steps
receiver,sender,mqtt-otel-trace-exporter), runcargo clippy --all-targetsandcargo test.pip install -r requirements.txtand the regenerated506-ros2-connectorrequirements.base.txt.Checklist
terraform fmton all Terraform codeterraform validateon all Terraform codeaz bicep formaton all Bicep codeaz bicep buildto validate all Bicep codeSecurity Review
Additional Notes
aiohttp3.14.1 → 3.13.5 move is a transitive consequence of thecheckov 3.3.6constraint (marked# via checkov), not a deliberate direct pin: checkov 3.3.6 (latest release) declaresaiohttp<3.14.0,>=3.8.0issue #641comment reference from pr-validation.yml.checkovdrops itsecdsadependency.Screenshots (if applicable)