Conversation
DHowett
reviewed
Apr 29, 2026
| locales.extend_sloppy( | ||
| arena, | ||
| val.split(':').filter(|s| !s.is_empty()).map(|s| { | ||
| // Replace all underscores with dashes, |
Member
There was a problem hiding this comment.
wait we already had "replace underscores with dashes"? how did this get broken
Member
Author
There was a problem hiding this comment.
Before we had the localization compiler, my hand-written localizations used dashes and so the sys code worked perfectly. This PR fixes the compiler.
I also simplified this code a bit as a drive-by. It makes no sense to allocate strings one by one. It's much better to do one allocation, split it and store just slices in the resulting vector.
DHowett
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _ -> - normalization was broken for both Windows and UNIX.
This changes the code to consistently expect "ab-cd" locales.
Closes #673