fix: advance email poll cursor by 1 ms to prevent restart re-push#6
Merged
brandwe merged 1 commit intoMay 27, 2026
Merged
Conversation
Graph's receivedDateTime gt filter can re-deliver messages at the cursor's exact second after a server restart when per-session dedup is lost. Bump the watermark by 1 ms after each poll batch and isolate email poll tests from blob env leakage.
Member
|
Thanks! I'll take this as soon as you agree to the cla @evanclan |
Contributor
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
advance_cursor()to bump the email poll watermark by 1 ms after each batch, so Graph'sreceivedDateTime gt {cursor}filter does not re-fetch messages at the cursor's exact second after a server restart (per-session dedup is lost on restart).ENTRACLAW_BLOB_*env vars in the email poll test fixture to avoid blob backend leakage on machines with cloud memory configured.Closes the P1 item tracked in
TODOS.md("Email cursor sub-second precision").Test plan
pytest tests/tools/test_email_poll.py -v(22 passed)ruff check src/entraclaw/tools/email_poll.py tests/tools/test_email_poll.pyMade with Cursor