feat(set item): support setting item definition paths#67
Merged
may-hartov merged 22 commits intomicrosoft:mainfrom Nov 24, 2025
Merged
feat(set item): support setting item definition paths#67may-hartov merged 22 commits intomicrosoft:mainfrom
may-hartov merged 22 commits intomicrosoft:mainfrom
Conversation
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
ayeshurun
reviewed
Nov 13, 2025
Co-authored-by: Alon Yeshurun <98805507+ayeshurun@users.noreply.github.com>
…y-hartov/fabric-cli into dev/mahartov/set_item_command
ohadedry
reviewed
Nov 17, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 19, 2025
ayeshurun
reviewed
Nov 23, 2025
ayeshurun
reviewed
Nov 23, 2025
ayeshurun
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of new changes
Expand and generalize the Set Item command to support setting any settable property in the item metadata and definition.
Currently, the Set Item command supports only a narrow range of properties (refer to ITMutablePropMap for the supported properties).
To enhance functionality, we should explore our options to expand and generalize the Set Item command to support setting any settable property in the item metadata and definition.
Notes:
-Item definition is a complex structure that can contain hundreds of properties.
-Item metadata settable properties are displayName and description. VariableLibrary also lets you set "properties".
Approach
Updated
set itemcommand-queryflag validation. Supported values:displayName,description,properties, andproperties.definitionor starts withdefinition.Backwards compatibility:
ITMutablePropMap, map to the corresponding path.Limitations:
-queryargument value.set item definitionusesexport itemto get the item definition and update the target property within it, and some properties are not included in the exported item (e.g., some default values), we support only setting properties that exist in theget itemresult.Additional Enhancements and Bug Fixes
GET / update definitiononly if the query has thedefinitionprefix. Otherwise, callGET / POST itemAPIs.notebooks/notebookIdrather thanitems/notebookId.get itemcore API doesn’t always return the workload’s specific metadata.