feat: ensure behaviors connected prior to template rendering#6471
Merged
nicholasrice merged 5 commits intomasterfrom Oct 25, 2022
Merged
Conversation
nicholasrice
requested review from
EisenbergEffect,
chrisdholt and
janechu
as code owners
📊 Tachometer Benchmark ResultsSummaryclickTrigger10x
create10k
createDelete5x
runFile1k
update10th
usedJSHeapSize
Resultsobservable-runFile1k
runFile1k
usedJSHeapSize
render-create10k
create10k
usedJSHeapSize
render-createDelete5x
createDelete5x
usedJSHeapSize
render-update10th
update10th
usedJSHeapSize
repeat-basic-splice-itemCount=1000&deleteCount=20&addCount=20
clickTrigger10x
usedJSHeapSize
repeat-nested-push-itemCount=100&addCount=20
clickTrigger10x
usedJSHeapSize
repeat-nested-reverse-itemCount=100
clickTrigger10x
usedJSHeapSize
repeat-nested-shift-itemCount=100
clickTrigger10x
usedJSHeapSize
repeat-nested-unshift-itemCount=100&addCount=20
clickTrigger10x
usedJSHeapSize
|
eljefe223
approved these changes
Oct 25, 2022
YusakuNo1
reviewed
Oct 25, 2022
| if (this.needsInitialization) { | ||
| this.finishInitialization(); | ||
| } else if (this.view !== null) { | ||
| this.view.bind(this.source); |
Contributor
There was a problem hiding this comment.
For the previous issue, is it because this.view.bind(this.source) is called before key.connectedCallback && key.connectedCallback(this);? Silly question: is it possible this.needsInitialization is false, but this.boundObservables !== null?
Contributor
Author
There was a problem hiding this comment.
Sorry, which previous issue?
No, that case is not possible. Both of those conditions can only be true before / during the first connection of the controller. However, it is possible that boundObservables is null while needsInitialization is true.
Contributor
There was a problem hiding this comment.
Sorry, I mean the "current issue". I got the answer now, thx :)
…ior-to-template-rendering
…ior-to-template-rendering
EisenbergEffect
approved these changes
Oct 25, 2022
Contributor
EisenbergEffect
left a comment
EisenbergEffect
left a comment
There was a problem hiding this comment.
Looks good. Glad we reverted the isConnected change. I had a feeling that was going to break some things.
chrisdholt
approved these changes
Oct 25, 2022
nicholasrice
deleted the
users/nirice/ensure-behaviors-connected-prior-to-template-rendering
branch
9 tasks
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* feature and tests * Change files * Set isConnected at end of connect call to preserve existing behavior Co-authored-by: nicholasrice <nicholasrice@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR adjusts
ElementController.connect()to change the order in which behaviors are rendered relative to the element template. Behaviors should be connected before templates are rendered so that they're able to support setting context for child / shadowed elements.I've also moved where theElementControllersetsisConnectedto before behaviors are connected.This was done so that behaviors can add other behaviors and have them be connected immediately.I reverted this change because it broke component expectations and it turns out that since we use a Map to store behaviors, the itterable keys update when behaviors add other behaviors, giving the desired behavior w/o moving thesetIsConnected()call.🎫 Issues
#6462
👩💻 Reviewer Notes
I wasn't exactly sure when the Controller should setisConnectedduring connection and disconnection. I don't want to over-complicate that property, but I did consider expanding it to be'connected','disconnected','connecting','disconnecting'to remove ambiguity on which state it is in.📑 Test Plan
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps