Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the @microsoft/fast-html binding test fixture to be generated via @microsoft/fast-build, replacing a hand-authored index.html with an entry.html + templates.html + state.json input set and adding it to the fixture build script for reproducible regeneration.
Changes:
- Add
entry.html,templates.html, andstate.jsoninputs for thebindingfixture. - Update
binding/index.htmlto thefast-build-generated output (including declarative shadow DOM + injected<f-template>declarations). - Extend
scripts/build-fixtures.jsto build thebindingfixture and add a Beachball change file.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/fast-html/test/fixtures/binding/templates.html | Adds the binding templates consumed by fast-build and injected into the generated fixture output. |
| packages/fast-html/test/fixtures/binding/state.json | Adds deterministic state values used to render the binding fixture at build time. |
| packages/fast-html/test/fixtures/binding/entry.html | Adds the fast-build entry document that references state-bound attributes for rendering. |
| packages/fast-html/test/fixtures/binding/index.html | Replaces the hand-authored fixture HTML with the generated output used by Playwright tests. |
| packages/fast-html/scripts/build-fixtures.js | Includes binding in the list of fixtures built via @microsoft/fast-build. |
| change/@microsoft-fast-html-binding-00c4aaaf-c636-4dc7-af40-8cd01ae1d4c9.json | Records the chore change for release tooling (type none). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
@microsoft/fast-buildto generate theindex.htmlfor thebindingtest fixture in@microsoft/fast-html, replacing the previously hand-authored file with a reproducible build step.