Conversation
…ture Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Regenerate repeat-event/index.html after rebasing onto main (which includes #7381 repeat fixture, #7380 when fixture, and #7403 entry-attribute stripping). Non-primitive binding attrs (items) are now stripped from entry element opening tags; primitive attrs (show-names="true") are preserved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
janechu
force-pushed
the
users/janechu/update-fixture-to-use-fast-build-repeat-event
branch
from
67d4c45 to
a890a18
Compare
Entry custom elements now have no attributes — the full root state JSON
is passed implicitly. Template keys are aligned with state.json:
- test-element-repeat-event: {{item in items}} → {{item in repeatEventItems}}
- test-when-in-repeat: {{item in items}} → {{item in whenRepeatItems}}
- f-when condition: {{c.parent.showNames}} → {{showNames}} (resolved
directly from root state, no context traversal needed)
entry.html updated: all {{binding}} attrs removed from both elements.
Fixture index.html regenerated.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Rename @observable properties to match the state.json keys and template expressions: - TestElementRepeatEvent.items → repeatEventItems - TestWhenInRepeat.items → whenRepeatItems Update repeat-event.spec.ts to use the new property name. Update comment on TestWhenInRepeat to reflect the simplified binding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
janechu
deleted the
users/janechu/update-fixture-to-use-fast-build-repeat-event
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Adds the
repeat-eventtest fixture to the set of fixtures built automatically by@microsoft/fast-build.The
repeat-eventfixture exercises two scenarios:test-element-repeat-event: af-repeatover a list of items where each item renders a<button>that fires a custom click handler via@click.test-when-in-repeat: af-repeatcombined with af-wheninside each item, conditionally rendering a named button based on the parent element'sshowNamesobservable.The
build-fixtures.jsscript is updated to include"repeat-event"in the fixtures list.📑 Test Plan
Run
npm run build:fixtures -w @microsoft/fast-htmlto regenerate all fixtures — all eight should build without errors. The Playwright tests for the repeat-event fixture can be verified by runningnpx playwright testinsidepackages/fast-html.✅ Checklist
General
$ npm run change