fix: add files and remove npmignore#7500
Merged
janechu merged 1 commit intoreleases/fast-element-v3from Apr 29, 2026
Merged
Conversation
chrisdholt
approved these changes
Apr 29, 2026
| } | ||
| }, | ||
| "files": [ | ||
| "./dist", |
Member
There was a problem hiding this comment.
Will this still have the tests in them?
Collaborator
Author
There was a problem hiding this comment.
Great question, no because we went from Karma to Playwright, so we do not need to compile our tests to JS, as such they never make it to ./dist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
The old
.npmignorewas too cumbersome and missed new files going in. This opt-in strategy with thefilesproperty ofpackage.jsonis a much cleaner and easier to maintain approach for package contents.✅ Checklist
General
$ npm run change