fix(fast-test-harness): preserve subdirectory structure in generateStylesheets outDir#7535
Merged
Conversation
chrisdholt
approved these changes
May 28, 2026
janechu
pushed a commit
that referenced
this pull request
May 28, 2026
…ylesheets outDir (#7535) * fix: correct output directory structure for generated CSS files * Change files
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
generateStylesheetsflattened per-component subdirectories when anoutDirwas supplied. Every generated.cssfile landed directly inoutDir/instead ofoutDir/<component>/<component>.styles.css, unlikegenerateFTemplates, which preserves the source structure.The fix applies the same
path.relative(distDir, ...)join already used ingenerate-templates.ts.📑 Test Plan
Added a
should preserve subdirectory structure in outDirtest mirroring the equivalent template generator test. The existingshould write to outDir when specifiedtest still passes.✅ Checklist
General
$ npm run change