Skip to content

Conversation

@LTA-Thinking
Copy link
Contributor

Description

Add extra logging

Related issues

Addresses [issue #].

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@LTA-Thinking LTA-Thinking requested a review from a team as a code owner May 14, 2025 19:11
GO
INSERT INTO dbo.SchemaVersion
VALUES (87, 'started');
VALUES (88, 'started');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why these changes are showing, they are already in the reference branch.

}
}

public static (Stopwatch sw, string label) StartStopwatch(this ILogger logger, string label)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Health shared has ActionTimer, that is kind of like this but uses an IDisposable to automatically start/stop the timer - https://github.com/microsoft/healthcare-shared-components/blob/d039a4e72fa3988f490f9349f674b17808055038/src/Microsoft.Health.Core/ActionTimerExtensions.cs

@LTA-Thinking
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LTA-Thinking LTA-Thinking merged commit e08b7b2 into hotfix/mediatr-logging May 23, 2025
36 of 43 checks passed
@LTA-Thinking LTA-Thinking deleted the personal/rojo/extra-mediatr-logging branch May 23, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants