Skip to content

Disable local auth for the cosmos db (S360 item)#5528

Merged
v-rachitsh merged 2 commits intomainfrom
personal/v-rachitsh/disablecosmosdblocalauth
Apr 29, 2026
Merged

Disable local auth for the cosmos db (S360 item)#5528
v-rachitsh merged 2 commits intomainfrom
personal/v-rachitsh/disablecosmosdblocalauth

Conversation

@v-rachitsh
Copy link
Copy Markdown
Contributor

Description

In provision-deploy.yml, the New-AzCosmosDBAccount call does not include the -DisableKeyBasedMetadataWriteAccess or a way to disable local auth. The ARM template at default-azuredeploy-docker.json has "disableLocalAuth": true hardcoded, but this template is not used by the PR provisioning pipeline — the PR pipeline uses the PowerShell New-AzCosmosDBAccount cmdlet directly, which defaults to local auth enabled.

Related issues

Addresses User Story 190850

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

…ude the -DisableKeyBasedMetadataWriteAccess or a way to disable local auth. The ARM template at default-azuredeploy-docker.json has "disableLocalAuth": true hardcoded, but this template is not used by the PR provisioning pipeline — the PR pipeline uses the PowerShell New-AzCosmosDBAccount cmdlet directly, which defaults to local auth enabled.
@v-rachitsh v-rachitsh added this to the FY26\Q4\2Wk\2Wk22 milestone Apr 29, 2026
@v-rachitsh v-rachitsh requested a review from a team as a code owner April 29, 2026 19:18
@v-rachitsh v-rachitsh added Bug-Security Security related bugs. No-PaaS-breaking-change ADR-Included ADR Included in the PR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Apr 29, 2026
rajithaalurims
rajithaalurims previously approved these changes Apr 29, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@fc47539). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5528   +/-   ##
=======================================
  Coverage        ?   77.10%           
=======================================
  Files           ?      983           
  Lines           ?    35994           
  Branches        ?     5466           
=======================================
  Hits            ?    27754           
  Misses          ?     6900           
  Partials        ?     1340           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@v-rachitsh v-rachitsh merged commit 220b758 into main Apr 29, 2026
49 checks passed
@v-rachitsh v-rachitsh deleted the personal/v-rachitsh/disablecosmosdblocalauth branch April 29, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ADR-Included ADR Included in the PR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug-Security Security related bugs. No-PaaS-breaking-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants