Skip to content

Fix ReindexTests by removing unnecessary search parameter cleanup#5543

Merged
jestradaMS merged 2 commits intomainfrom
users/jestrada/fixreindextestperfregression
May 2, 2026
Merged

Fix ReindexTests by removing unnecessary search parameter cleanup#5543
jestradaMS merged 2 commits intomainfrom
users/jestrada/fixreindextestperfregression

Conversation

@jestradaMS
Copy link
Copy Markdown
Contributor

@jestradaMS jestradaMS commented May 2, 2026

Description

Remove WaitForSearchParameterCleanupAsync from ReindexTests as url uniqueness should handle the previous flakiness caused by search param collisions on replicas which have not had cache convergence.

Related issues

Addresses [issue #].

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@jestradaMS jestradaMS added this to the FY26\Q4\2Wk\2Wk22 milestone May 2, 2026
@jestradaMS jestradaMS requested a review from a team as a code owner May 2, 2026 13:28
@jestradaMS jestradaMS added Bug Bug bug bug. Build OSS-specific This is category of issues that are specific to OSS. This category does not impact managed service. labels May 2, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.39%. Comparing base (a894a3b) to head (2fab399).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5543      +/-   ##
==========================================
+ Coverage   77.02%   77.39%   +0.36%     
==========================================
  Files         983      983              
  Lines       36007    36007              
  Branches     5469     5469              
==========================================
+ Hits        27736    27869     +133     
+ Misses       6927     6795     -132     
+ Partials     1344     1343       -1     

see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jestradaMS jestradaMS enabled auto-merge (squash) May 2, 2026 15:01
@jestradaMS jestradaMS merged commit 929c811 into main May 2, 2026
78 of 83 checks passed
@jestradaMS jestradaMS deleted the users/jestrada/fixreindextestperfregression branch May 2, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Bug bug bug. Build OSS-specific This is category of issues that are specific to OSS. This category does not impact managed service.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants