Fix ReindexTests by removing unnecessary search parameter cleanup#5543
Merged
jestradaMS merged 2 commits intomainfrom May 2, 2026
Merged
Fix ReindexTests by removing unnecessary search parameter cleanup#5543jestradaMS merged 2 commits intomainfrom
jestradaMS merged 2 commits intomainfrom
Conversation
…p logic to improve test performance
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5543 +/- ##
==========================================
+ Coverage 77.02% 77.39% +0.36%
==========================================
Files 983 983
Lines 36007 36007
Branches 5469 5469
==========================================
+ Hits 27736 27869 +133
+ Misses 6927 6795 -132
+ Partials 1344 1343 -1 🚀 New features to boost your workflow:
|
PTaladay
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove WaitForSearchParameterCleanupAsync from ReindexTests as url uniqueness should handle the previous flakiness caused by search param collisions on replicas which have not had cache convergence.
Related issues
Addresses [issue #].
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)