Skip to content

FinOps alerts fix for deployment bug #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ro100e merged 6 commits into from
Apr 15, 2025
Merged

FinOps alerts fix for deployment bug #1511

ro100e merged 6 commits into from
Apr 15, 2025

Conversation

@ro100e
Copy link
Contributor

@ro100e ro100e commented Apr 11, 2025 •
edited
Loading

🛠️ Description

Update logicApp.bicep to fix deployment bug for FinOps alerts

Fixes #
#1481

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@microsoft-github-policy-service microsoft-github-policy-service bot added Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed labels Apr 11, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Skill: Deployment Resource deployment automation via bicep or terraform label Apr 11, 2025
@ro100e ro100e mentioned this pull request Apr 11, 2025
Closed
@ro100e ro100e changed the title FinOps alerts fixe for deployment bug FinOps alerts fix for deployment bug Apr 11, 2025
flanakin
flanakin approved these changes Apr 12, 2025
View reviewed changes
ro100e and others added 4 commits April 12, 2025 23:15
@ro100e @flanakin
Update src/templates/finops-alerts/modules/logicApp.bicep
e04fe1c 
Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
@ro100e @flanakin
Update src/templates/finops-alerts/modules/logicApp.bicep
6ef6895 
Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
@ro100e
update changelog
a0c5438
@ro100e
Merge branches 'robelm/finops-alerts-patch-1' and 'robelm/finops-aler…
d63cbc9 
…ts-patch-1' of https://github.com/microsoft/finops-toolkit into robelm/finops-alerts-patch-1
@flanakin flanakin added Status: ▶️ Ready Issue is ready for a dev to start work and removed Needs: Review 👀 PR that is ready to be reviewed labels Apr 15, 2025
@ro100e ro100e merged commit e9d6e6c into dev Apr 15, 2025
3 checks passed
@ro100e ro100e deleted the robelm/finops-alerts-patch-1 branch April 15, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arthurclares arthurclares Awaiting requested review from arthurclares arthurclares is a code owner

@FallenHoot FallenHoot Awaiting requested review from FallenHoot

@flanakin flanakin Awaiting requested review from flanakin flanakin is a code owner

Assignees

@flanakin flanakin

@FallenHoot FallenHoot

@arthurclares arthurclares

Labels

Micro PR 🔬 Very small PR that should be especially easy for newcomers Skill: Deployment Resource deployment automation via bicep or terraform Status: ▶️ Ready Issue is ready for a dev to start work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ro100e @flanakin @FallenHoot @arthurclares