Skip to content

Conversation

@flanakin
Copy link
Collaborator

🛠️ Description

  • Move script storage to a new core-network.bicep file (will move networking components later)
  • Move storage container creation to hub-app.bicep
  • Created new types to hold state (still in-memory for now)

Related to #1400

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin added this to the 2025-04 - April milestone Apr 15, 2025
@flanakin flanakin enabled auto-merge (squash) April 15, 2025 00:21
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review 👀 PR that is ready to be reviewed label Apr 15, 2025
@flanakin flanakin added the Tool: FinOps hubs Data pipeline solution label Apr 15, 2025
@flanakin flanakin disabled auto-merge May 2, 2025 20:16
@flanakin flanakin merged commit fae86c3 into dev May 3, 2025
3 checks passed
@flanakin flanakin deleted the flanakin/dev/hubapps-appstorage branch May 3, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants