Skip to content

[V2 Bottom drawer] Drawer shifting up with IME open for SDK versions less than 33#726

Merged
joyeeta26 merged 3 commits intomasterfrom
joypal/BottomDrawerIME
Nov 8, 2024
Merged

[V2 Bottom drawer] Drawer shifting up with IME open for SDK versions less than 33#726
joyeeta26 merged 3 commits intomasterfrom
joypal/BottomDrawerIME

Conversation

@joyeeta26
Copy link
Copy Markdown
Contributor

@joyeeta26 joyeeta26 commented Nov 7, 2024

Problem

For SDK version less than 33, extra padding was seen between bottom drawer when IME opens
image

Root cause

The extra spacing issue for API versions less than 33 when using WindowManager.LayoutParams.MATCH_PARENT for the height of the modal window is likely due to differences in how the window manager handles layout parameters in different Android versions.

Fix

For API versions less than 33, the WindowManager.LayoutParams.WRAP_CONTENT has been used to ensure the modal window only takes up the necessary space without adding extra spacing.

Validations

drawer ime

Screenshots

Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • Automated Tests
  • Documentation and demo app examples
  • VoiceOver and Keyboard Accessibility
  • Internationalization and RTL layouts
  • Size classes and window sizes (notched devices, multitasking, different window sizes, etc)

@joyeeta26 joyeeta26 requested a review from a team as a code owner November 7, 2024 12:17
@joyeeta26 joyeeta26 changed the title [Bottom drawer] Fix Extra padding issue with IME for SDK versions less than 33 [V2 Bottom drawer] Drawer shifting up with IME open for SDK versions less than 33 Nov 8, 2024
@joyeeta26 joyeeta26 merged commit 651d48f into master Nov 8, 2024
Dhruv-Mishra pushed a commit that referenced this pull request Jan 21, 2025
[V2 Bottom drawer] Drawer shifting up with IME open for SDK versions less than 33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants