[V2 Bottom drawer] Drawer shifting up with IME open for SDK versions less than 33#726
Merged
[V2 Bottom drawer] Drawer shifting up with IME open for SDK versions less than 33#726
Conversation
Anubhvv
approved these changes
Nov 7, 2024
Dhruv-Mishra
pushed a commit
that referenced
this pull request
Jan 21, 2025
[V2 Bottom drawer] Drawer shifting up with IME open for SDK versions less than 33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For SDK version less than 33, extra padding was seen between bottom drawer when IME opens

Root cause
The extra spacing issue for API versions less than 33 when using WindowManager.LayoutParams.MATCH_PARENT for the height of the modal window is likely due to differences in how the window manager handles layout parameters in different Android versions.
Fix
For API versions less than 33, the WindowManager.LayoutParams.WRAP_CONTENT has been used to ensure the modal window only takes up the necessary space without adding extra spacing.
Validations
Screenshots
Pull request checklist
This PR has considered: