[dev-v5][DataGrid] Fix SelectColumn issue #4497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.9%
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports the DataGrid SelectColumn fix to v5, ensuring the header “Select All” state correctly reflects row selection when using the Property predicate, and tweaks analyzer handling in the grid disposal logic.
Changes:
- Updated
SelectColumn<TGridItem>.SelectAllto be nullable without a default, aligning with the documentation thatnullmeans “undefined”. - Adjusted
SelectColumn<TGridItem>.GetSelectAll()to considerInternalGridContext.Items.Any(Property)so the header state matches items that are initially selected via thePropertyselector. - Added MA0042 pragma suppression around
_scope?.Dispose()inFluentDataGrid<TGridItem>.DisposeAsync()to silence analyzer warnings about blocking calls in an async method.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Core/Components/DataGrid/FluentDataGrid.razor.cs |
Adds targeted MA0042 suppression around synchronous _scope?.Dispose() in the async DisposeAsync override, matching existing analyzer-handling patterns. |
src/Core/Components/DataGrid/Columns/SelectColumn.cs |
Aligns SelectAll’s default and header-selection logic with the documented nullable semantics and fixes the header “Select All” state when rows are initially selected via the Property predicate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dvoituron
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of PR #4491 for v5