[Tabs] Call HandleOnTabChange when changing to a tab through the menu#4564
Merged
[Tabs] Call HandleOnTabChange when changing to a tab through the menu#4564
Conversation
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61%
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request attempts to fix an issue where the OnTabChange callback was not being invoked when switching to a tab through the overflow menu. The change adds a call to HandleOnTabChangedAsync at the end of OnTabChangeHandlerAsync, which is called when tabs are changed programmatically, through the overflow menu, or when tabs are unregistered.
Changes:
- Added call to
HandleOnTabChangedAsyncinOnTabChangeHandlerAsyncmethod to ensureOnTabChangecallback fires for all tab change scenarios
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dvoituron
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a small change to the tab change handler in
FluentTabs.razor.cs. Now, after invoking theOnTabSelectevent, it also callsHandleOnTabChangedAsync, ensuring any additional logic tied to tab changes is executed.Fix #4549