[dev-v5][Nav] Calculate height of active bar (instead of fixed value)#4580
Merged
[dev-v5][Nav] Calculate height of active bar (instead of fixed value)#4580
Conversation
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.8%
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates FluentNav’s active indicator styling to size the active bar relative to the active item’s height rather than using a fixed height.
Changes:
- Changed the active indicator pseudo-element height from a fixed
20pxtocalc(100% - 20px).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dvoituron
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title says it all