Use an AssemblyLoadContext to read correct DLL versions#4829
Merged
Conversation
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.7%
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the FluentUI.Demo.DocApiGen tool to load target assemblies via a dedicated AssemblyLoadContext, so plugin assemblies and their dependencies resolve from the plugin’s directory (reducing version-conflict risk vs loading into the default context).
Changes:
- Introduced
PluginAssemblyLoadContext(usingAssemblyDependencyResolver) to resolve managed/unmanaged dependencies relative to a target DLL. - Updated
Program.csto load the target DLL through the new load context instead ofAssembly.LoadFile.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| examples/Tools/FluentUI.Demo.DocApiGen/Program.cs | Switches assembly loading to PluginAssemblyLoadContext and adds related imports/suppression. |
| examples/Tools/FluentUI.Demo.DocApiGen/AssemblyLoading/PluginAssemblyLoadContext.cs | Adds a custom AssemblyLoadContext that probes dependencies via .deps.json and the plugin directory. |
dvoituron
requested changes
May 6, 2026
dvoituron-msft
approved these changes
May 6, 2026
dvoituron
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a custom assembly loading mechanism to the
FluentUI.Demo.DocApiGentool, ensuring that plugin assemblies and their dependencies are loaded from the correct directory and avoiding version conflicts. The main change is the addition of a newPluginAssemblyLoadContextclass and its integration into the program's assembly loading logic.Assembly loading improvements:
PluginAssemblyLoadContextclass inPluginAssemblyLoadContext.csthat inherits fromAssemblyLoadContext. This class resolves managed and unmanaged dependencies from the same directory as the target DLL, preventing version conflicts with assemblies already loaded in the default context.Program.csto usePluginAssemblyLoadContextfor loading the target assembly, replacing the previous use ofAssembly.LoadFile. This ensures dependencies are resolved correctly for plugin scenarios.usingstatement for the new assembly loading namespace inProgram.cs.