[dev-v5] Implement nullable parameter validation in FluentInput components#4847
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.7%
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new guard to prevent null values from being assigned to selected FluentInput component parameters during parameter-setting, aiming to avoid runtime breakage caused by null IDs.
Changes:
- Added a
ParameterViewextension (ThrowNullableParameters) that throws when specified parameters are explicitly provided asnull. - Overrode
FluentInputBase<TValue>.SetParametersAsyncto enforce non-nullIdwhen supplied via parameters.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Core/Extensions/FluentInputExtensions.cs | Introduces ThrowNullableParameters helper to detect explicitly-supplied null parameters and throw a descriptive exception. |
| src/Core/Components/Base/FluentInputBase.cs | Uses the new helper in SetParametersAsync to reject Id=null being passed into FluentInputBase-derived components. |
vnbaaij
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[dev-v5] Implement nullable parameter validation in FluentInput components
Introduce validation for nullable parameters in FluentInput components to prevent
nullvalues from being assigned to critical parameters.This change enhances the robustness of the component by ensuring that required parameters are not null during rendering.
See #4846
For example, this code
will generate this exception
System.InvalidOperationException: The 'Id' parameter of 'FluentDatePicker1' cannot be null.`Unit Tests
Added