[dev-v5} Refactor color picker for improved touch interactions#4880
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors the color picker’s drag handling so document-level listeners are only attached during an active drag, improving touch/drag UX and avoiding global scroll blocking when idle.
Changes:
- Replaces dual boolean drag flags with a single
draggingtarget state ('square' | 'hue'). - Attaches/removes
documentmove/end listeners dynamically during drag start/stop. - Stores element/document handler references on state to ensure proper cleanup in
Dispose.
Unit Tests
Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.7%
|
vnbaaij
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[dev-v5} Refactor color picker for improved touch interactions
Enhance the color picker by refactoring event handling to better support touch and drag interactions. This change improves user experience on touch devices and ensures smoother functionality during color selection.
No breaking changes introduced.