-
Notifications
You must be signed in to change notification settings - Fork 171
Tokenize button Android/iOS #2337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
68edecb
Button/FAB Tokenization Complete
ayush547 0a26f73
Update readme
ayush547 7b1ecbb
Updated snapshots
ayush547 ee59460
Added support for inner border
ayush547 ea24a94
Merge branch 'microsoft:main' into tokenize-android-button
ayush547 5079bc1
Updated tester app text for mobile
ayush547 e92955f
Merge branch 'microsoft:main' into tokenize-android-button
ayush547 e50bc12
Change files
ayush547 28084d1
Merge branch 'microsoft:main' into tokenize-android-button
ayush547 95e0226
Resolved comments
ayush547 fb154c7
Removed extra features from Android Tester
ayush547 8353e03
Merge branch 'tokenize-android-button' of https://github.com/ayush547…
ayush547 ffb9394
Updated to use shared iconExamples
ayush547 66995b5
Resolve conflicts
ayush547 8f5dc5b
Removed unsupported buttons from SizeTest
ayush547 0036c90
Resolved comments
ayush547 26b182e
Resolved comments
ayush547 9c23222
Removed explicit mapping to default for outline
ayush547 4c16926
Prettier fix
ayush547 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
apps/fluent-tester/src/TestComponents/Button/ButtonIconTestSection.android.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import { ButtonV1 as Button } from '@fluentui/react-native'; | ||
| import * as React from 'react'; | ||
| import { View } from 'react-native'; | ||
| import { commonTestStyles, testContentRootViewStyle } from '../Common/styles'; | ||
| import { svgProps } from '../Common/iconExamples'; | ||
|
|
||
| export const ButtonIconTest: React.FunctionComponent = () => { | ||
| const fontBuiltInProps = { | ||
| fontFamily: 'Arial', | ||
| codepoint: 0x2663, | ||
| fontSize: 24, | ||
| }; | ||
|
|
||
| /* eslint-disable @typescript-eslint/no-var-requires */ | ||
| const testImage = require('../../../../assets/icon_24x24.png'); | ||
|
|
||
| return ( | ||
| <View style={testContentRootViewStyle}> | ||
| <Button icon={{ fontSource: fontBuiltInProps }} style={commonTestStyles.vmargin}> | ||
| Font icon | ||
| </Button> | ||
| <Button appearance="accent" icon={{ svgSource: svgProps, color: 'black' }} style={commonTestStyles.vmargin}> | ||
| SVG | ||
| </Button> | ||
| <Button icon={testImage} style={commonTestStyles.vmargin}> | ||
| PNG | ||
| </Button> | ||
| </View> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
apps/fluent-tester/src/TestComponents/Button/ButtonVariantTestSection.android.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import { Button, FAB } from '@fluentui-react-native/experimental-button'; | ||
| import * as React from 'react'; | ||
| import { View } from 'react-native'; | ||
| import { commonTestStyles, testContentRootViewStyle } from '../Common/styles'; | ||
| import { iconProps } from '../Common/iconExamples'; | ||
|
|
||
| export const ButtonVariantTest: React.FunctionComponent = () => { | ||
| const [showFABText, setShowFABText] = React.useState(true); | ||
| const flipFABcontent = React.useCallback(() => setShowFABText(!showFABText), [showFABText]); | ||
|
|
||
| return ( | ||
| <View style={testContentRootViewStyle}> | ||
|
ayush547 marked this conversation as resolved.
|
||
| <Button style={commonTestStyles.vmargin}>Default</Button> | ||
| <Button disabled style={commonTestStyles.vmargin}> | ||
| Default Disabled | ||
| </Button> | ||
| <Button appearance="accent" style={commonTestStyles.vmargin}> | ||
| Accent | ||
| </Button> | ||
| <Button disabled appearance="accent" style={commonTestStyles.vmargin}> | ||
| Accent Disabled | ||
| </Button> | ||
| <Button appearance="outline" style={commonTestStyles.vmargin}> | ||
| Outline | ||
| </Button> | ||
| <Button appearance="outline" disabled style={commonTestStyles.vmargin}> | ||
| Outline Disabled | ||
| </Button> | ||
| <Button appearance="subtle" style={commonTestStyles.vmargin}> | ||
| Subtle | ||
| </Button> | ||
| <Button appearance="subtle" disabled style={commonTestStyles.vmargin}> | ||
| Subtle Disabled | ||
| </Button> | ||
| <FAB icon={iconProps} iconOnly disabled style={commonTestStyles.vmargin} /> | ||
| <FAB icon={iconProps} style={commonTestStyles.vmargin} showContent={showFABText} onClick={flipFABcontent}> | ||
| Click Me! | ||
| </FAB> | ||
| <FAB appearance="subtle" iconOnly disabled icon={iconProps} style={commonTestStyles.vmargin} /> | ||
| <FAB appearance="subtle" icon={iconProps} style={commonTestStyles.vmargin} showContent={showFABText} onClick={flipFABcontent}> | ||
| Click Me! | ||
| </FAB> | ||
| </View> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-native-button-10ae7399-8b50-4819-9785-4dc9f2415ed3.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "minor", | ||
| "comment": "Button/FAB Tokenization Complete", | ||
| "packageName": "@fluentui-react-native/button", | ||
| "email": "ayushsinghs@yahoo.in", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
...@fluentui-react-native-experimental-menu-button-d4f0727b-84d8-407b-b63b-c77f4397779b.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "Button/FAB Tokenization Complete", | ||
| "packageName": "@fluentui-react-native/experimental-menu-button", | ||
| "email": "ayushsinghs@yahoo.in", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-native-menu-8ef2c740-67ab-4533-b57e-7bcd9d13cc9f.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "Button/FAB Tokenization Complete", | ||
| "packageName": "@fluentui-react-native/menu", | ||
| "email": "ayushsinghs@yahoo.in", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-native-menu-button-b02de3bf-aecb-4b2a-9cf4-b2faa906dac2.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "Button/FAB Tokenization Complete", | ||
| "packageName": "@fluentui-react-native/menu-button", | ||
| "email": "ayushsinghs@yahoo.in", | ||
| "dependentChangeType": "none" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-native-tester-8c6fbb58-2489-4431-bbc4-5ff0ab26cbf6.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "minor", | ||
| "comment": "Updated tester app text for mobile", | ||
| "packageName": "@fluentui-react-native/tester", | ||
| "email": "ayushsinghs@yahoo.in", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-native-tokens-427dc551-93f2-484d-8b21-006a3b0a4217.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "minor", | ||
| "comment": "Added padding start and end to LayoutTokens", | ||
| "packageName": "@fluentui-react-native/tokens", | ||
| "email": "ayushsinghs@yahoo.in", | ||
| "dependentChangeType": "patch" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.