[Switch] Animation using Animated API , Removing LayoutAnimation #2457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanprasadofficial
force-pushed
the
switch-animation
branch
2 times, most recently
from
65683b6 to
d63358b
Compare
rohanprasadofficial
force-pushed
the
switch-animation
branch
from
d63358b to
d5cf69b
Compare
rohanprasadofficial
force-pushed
the
switch-animation
branch
from
083d91a to
fec6a2c
Compare
Contributor
Author
|
Animation work with Animated API as well on iOS. Screen.Recording.2022-12-23.at.2.47.42.PM.mov |
Contributor
Author
|
Screen recording for Android - Switch Animation Screen.Recording.2022-12-23.at.4.45.55.PM.mov |
rohanprasadofficial
changed the title
rohanprasadofficial
changed the title
Contributor
Author
|
Latest screenshot with correct token values :
|
rurikoaraki
reviewed
Dec 28, 2022
rurikoaraki
reviewed
Dec 28, 2022
rurikoaraki
reviewed
Dec 28, 2022
rurikoaraki
reviewed
Dec 28, 2022
rurikoaraki
reviewed
Jan 4, 2023
rurikoaraki
reviewed
Jan 4, 2023
Saadnajmi
reviewed
Jan 4, 2023
rurikoaraki
reviewed
Jan 4, 2023
rurikoaraki
reviewed
Jan 4, 2023
Contributor
Author
|
Latest screenshot with correct token values :
IPhone/iOS screenshot with incorrect token :
|
Contributor
Author
IPhone/iOS screen current behaviour with incorrect tokens.Screen.Recording.2023-01-04.at.4.45.35.PM.movAndroid screen current behaviour with correct tokens.Screen.Recording.2023-01-04.at.3.44.27.PM.mov |
rurikoaraki
reviewed
Jan 4, 2023
Collaborator
|
Tested on win32, behavior looks good |
rurikoaraki
reviewed
Jan 4, 2023
Contributor
Author
Thanks for testing it @rurikoaraki , really appreciate your time 😃 |
rurikoaraki
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
This PR targets to make work animation on switch using Animated API instead of Layout Animations.
Layout Animations are very heaving and have effect on parent as well which using the Switch , there were some known bug like controlled switch was not working with Layout Animations.
Note :
This is only target Android for now but it will work on iOS , I have tested the animation on iOS as well.
Verification
Visual Verification.
Added the screenshot on both Android and iOS.
Pull request checklist
This PR has considered (when applicable):