DetailsRow - cellStyleProps prop now passed to getClassNames

[sgbdev]

Environment Information

• Package version(s): office-ui-fabric-react 7.105.12
• Browser and OS versions: Chrome: Version 80.0.3987.163 (Official Build) (64-bit), Microsoft Windows Version 1903 Build 18362.657

Please provide a reproduction of the bug in a codepen:

https://codepen.io/sgbdev/pen/zYvxKYo

Actual behavior:

When passing cellStyleProps to DetailsList, list cells still have default padding, while column headers use padding from cellStyleProps.

Column Header Padding

DetailsRow Padding

After doing some digging it looks like the DetailsRow.base.render method does not pass cellStyleProps to the getClassnames function. cellStyleProps is being passed to DetailsRow from the DetailsList.base._onRenderCell method.

Expected behavior:

DetailsRow should pass cellStyleProps to getClassNames function like it is in DetailsColumn.

Priorities and help requested:

Are you willing to submit a PR to fix? Maybe?

Requested priority: Normal

Products/sites affected: None known

[joschect]

@sgbdev Thanks for the submission! I see the behavior you're talking about. I believe you're correct that the issue is in DetailsRow.base. It certainly gets the correct styles passed to it, but the styles are then never passed down to the DetailsRowFields component. One example of that lack of data being passed down are these lines

@KevinTCoughlin I think it should be fine to pass the styles down. It's clear that DetailsRowFields is expecting those styles.

[KevinTCoughlin]

@sgbdev Thanks for the submission! I see the behavior you're talking about. I believe you're correct that the issue is in DetailsRow.base. It certainly gets the correct styles passed to it, but the styles are then never passed down to the DetailsRowFields component. One example of that lack of data being passed down are these lines

@KevinTCoughlin I think it should be fine to pass the styles down. It's clear that DetailsRowFields is expecting those styles.

Seems like a legitimate bug with a straightforward fix. I don't expect a problem so long as the styles do not mutate unnecessary across renders.

fluentui/packages/office-ui-fabric-react/src/components/DetailsList/DetailsRowFields.tsx

Line 31 in 9e3c7c7

cellStyleProps = DEFAULT_CELL_STYLE_PROPS,

[joschect]

@KevinTCoughlin Sounds good. I'll add this to our list to get it queued up for a fix.

[sgbdev]

@joschect I would be happy to submit a PR for this, if it would expedite it?

[KevinTCoughlin]

Strange the bot didn't autoclose this cc: @cliffkoh

[cliffkoh]

The closure of issues after a PR that fixes the issue is merged is handled by GitHub. GitHub didn't kick in here because the PR in question did not use a closing keyword properly (it explicitly hyperlinked to this issue rather than just # reference the issue number).