Accordion Convergence

[jurokapsiar]

Preparation:

• Started prep
• Open UI Research complete: feat(Accordion): adds accordion research  openui/open-ui#263
• Comparison on v8 and v0 complete
• Gather open GitHub issues related to component
• react-* package scaffolded
  • link to package
• Component Spec authored and reviewed
  • link to spec in component package
• Deliverable: Reviewed component spec

Implementation

link to react-* package folder

• Started impl
• Implement component
• Add storybook stories
• Using hooks
• Using makeStyles
• Respects Figma tokens (and using provider)
• Respects API principles, shorthands and slots handling
• No dependency on v0/v7
• Add tests - Conformance, Unit, and VR
  • Conformance tests
  • Unit tests
  • VR tests
  • Accessibility behavior tests
• Write README.md covering basic usage
• Write initial MIGRATION.md guide (include v8 and v0)
• Deliverable: Experimental component ready for partner use

Validation

• Started validating
• Add and validate in UI Builder
• Add and validate in docs site
• Validate with token pipeline
• Validate in product
• Finalize migration guide
  • Author codemods
• Deliverable: Preview component ready for broader/3rd party use

[JustSlone]

Update:

• Spec in review

Next:

• Implementing base component

Need:

• Working with Design on visual design - ETA this week

[JustSlone]

Update:

• Contextual behavior is a challenge, need to figure out approach here. Spending more time on Debate here
• Technically in implementation phase

[brandonthomas]

Update:

• Contextual behavior is a challenge, need to figure out approach here. Spending more time on Debate here
• Technically in implementation phase

Can we just leverage existing patterns similar to Customizer to address in context needs without breaking encapsulation? I get really concerned when components try to reach out of themselves and make assumptions. Usually leads to unexpected behavior. Would love to understand the approach here.

[bsunderhus]

The approach I'm adopting at the moment (after some discussion) is to use @reach/descendants, an internal library from Reach UI design system that was developed to manage this exact problem of comunicatin between compound components.

Please let me know if you have any thoughts or advices on the matter @brandonthomas