Clicking on anything non-focusable in the dialog focuses the dialog

[ling1726]

This is especially noticeable when there are scrollable containers inside the dialog. https://codesandbox.io/s/sad-sanne-77x373?file=/example.tsx

In the gif you can see that the input is blurred once the scrollbar is clicked

By default the mousedown event will propagate and focus a focusable parent (i.e. tabindex >= -1) if available. This can be detrimental when users want to have focus/blur related behaviour within the dialog because clicking on things like scrollbars should not blur a component like a combobox

[jurokapsiar]

related: https://bugs.chromium.org/p/chromium/issues/detail?id=1459926&q=&can=4

[bsunderhus]

Just as a reference, here's the issue where we decided to introduce tabIndex=-1 to the dialog surface #25150

By the problems mentioned on #25150, having this fix is only necessary for the scenarios where the Dialog has no focusable element on it. We could verify this on first render and then decide whether dialog surface should have tabIndex=-1 or not, the problem is that this solution will not work for any lazy loaded content inside of a dialog

[bsunderhus]

In the example provided, if you simply add tabIndex=undefined to DialogSurface the problem is solved

https://codesandbox.io/s/sad-sanne-77x373?file=/example.tsx

I guess the case here is: should we add tabIndex=-1 by default to every single DialogSurface (which is what we're doing right now) or should we have a fancy logic to decide whether tabIndex=-1 or tabIndex=undefined?

Also keeping in mind that whatever that fancy logic would do, it would only work having in mind the first render, as there's no way we can known if a focusable element will be introduced later on lazily.

[ling1726]

I suggest moving this issue to the backlog until we see more standard use cases that are affected.

We've only seen one use case where this tabindex causes problems. We found a simple enough workaround for that,

[microsoft-github-policy-service]

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.