Skip to content

MenuGridRow onClick handler not executing for mouse click #35855

@adamsamec

Description

@adamsamec

Component

Other...

Package version

9.73.2

React version

18.3.1

Environment

System:
    OS: Windows 11 10.0.26200
    CPU: (20) x64 13th Gen Intel(R) Core(TM) i7-1370P
    Memory: 11.60 GB / 31.66 GB
  Browsers:
    Chrome: 145.0.7632.160
    Edge: Chromium (145.0.3800.65)
    Firefox: 148.0 - C:\Program Files\Mozilla Firefox\firefox.exe
    Internet Explorer: 11.0.26100.7309

Current Behavior

This issue is related to the pull request #35795 Fix: Proper onClick handling for MenuGridRow.

The PR strives to solve the issue of onClick handler on MenuGridItem or MenuGridRow not being fired for Enter or spacebar pressess when row is focused, but the PR introduces a new issue of onClick handler for MenuGridItem or MenuGridRow not being executed for mouse click events on row.

Expected Behavior

The onClick handler for MenuGridItem or MenuGridRow should be fired properly for both mouse clicks and Enter/spacebar presses.

Reproduction

https://storybooks.fluentui.dev/react/?path=/docs/preview-components-menu-menugrid--docs

Steps to reproduce

  1. Visit MenuGrid storybook page.
  2. Click the "Chat participants" button under the "Default" story.
  3. Try clicking with mouse on some row.
  4. Try focusing some row with Down/Up arrow key and activating with Enter/spacebar. storybook: https://storybooks.fluentui.dev/react/?path=/docs/preview-components-menu-menugrid--docs

Are you reporting an Accessibility issue?

None

Suggested severity

Urgent - No workaround and Products/sites are affected

Products/sites affected

No response

Are you willing to submit a PR to fix?

yes

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions