Adding a prop shouldUpdateWhenHidden to decide whether to update hidden callouts#10465
Merged
msft-github-bot merged 3 commits intomicrosoft:masterfrom Sep 24, 2019
Merged
Conversation
added 2 commits
September 16, 2019 15:56
…en callouts and contextual menus
whykushal93
changed the title
Asset size changes
Baseline commit: 47d134d6e3ecdcdfb8406c2ad581c2dc3fe57906 (build) |
Contributor
Component Perf AnalysisNo significant results to display. All results
|
natalieethell
approved these changes
Sep 18, 2019
Contributor
|
@joschect can you take a look at this when you have a minute? |
joschect
approved these changes
Sep 24, 2019
Contributor
|
Hello @natalieethell! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Contributor
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Previously, to improve perf. we added code to stop updating a hidden callout or a contextual menu. This helped in not spending time to update Callouts which were not shown to the user.
Currently, we are working on a performance improvement that iteratively updates a hidden Callout during browser idle time. This would help us show a hidden Callout very fast to the user. For this however, we need the updates to propagated to a hidden callout as well. Hence, this change.
To maintain backwards compatibility and because in the default case, I still think it is valuable to not update a hidden Callout, I am introducing a prop rather than change behavior.
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow