Adding universal ThemeProvider package, initial checkin. #12996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ce5c014aa4c23951afe4d1ca5e45ddb711e2f0fc (build) |
ecraig12345
reviewed
May 5, 2020
Member
ecraig12345
left a comment
ecraig12345
left a comment
There was a problem hiding this comment.
Left some comments about build-related stuff.
Also from the lockfile it looks like there might be some dependency version mismatches.
xugao
reviewed
May 5, 2020
change/@fluentui-react-2020-05-05-09-14-40-feat-react-theme-provider.json
Outdated
Show resolved
Hide resolved
Contributor
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
khmakoto
reviewed
May 5, 2020
xugao
reviewed
May 6, 2020
xugao
reviewed
May 6, 2020
xugao
approved these changes
May 6, 2020
xugao
reviewed
May 6, 2020
Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
…eat/react-theme-provider
| const parentTheme = useTheme(); | ||
|
|
||
| // Merge the theme only when parent theme or props theme mutates. | ||
| const fullTheme = React.useMemo<ThemePrepared>(() => mergeThemes(parentTheme, theme), [parentTheme, theme]); |
Member
There was a problem hiding this comment.
As theme is a prop it can be inline object: <ThemeProvider theme={{ foo: 'bar' }} />. It means that all consumers will receive updates on each render as fullTheme is passed to React context.
Comment on lines
+26
to
+27
| { theme, style, className, ...rest }: React.PropsWithChildren<ThemeProviderProps>, | ||
| ref: React.Ref<HTMLDivElement>, |
Member
There was a problem hiding this comment.
There is no need to specify these types obviously
Contributor
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a universal generalized ThemeProvider package. It currently does 2 things:
See the
README.mdfor usage.Includes:
Microsoft Reviewers: Open in CodeFlow