ThemeProvider: support V7 theme #14398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fdda8e8:
|
Asset size changes
Baseline commit: 12b2fde208a5df3340a4538f93e9745a8d45e340 (build) |
xugao
force-pushed
the
xgao/themeprovider-supportv7them
branch
from
3135e6e to
5f42a4d
Compare
Contributor
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
xugao
added
Area: Theming
Fluent UI v8
and removed
PR: Possible Perf Regression 🐌
labels
xugao
force-pushed
the
xgao/themeprovider-supportv7them
branch
from
ecffa5b to
9da2d93
Compare
xugao
force-pushed
the
xgao/themeprovider-supportv7them
branch
from
9da2d93 to
6ebcd17
Compare
dzearing
reviewed
Aug 11, 2020
| theme={{ | ||
| semanticColors: { | ||
| primaryButtonBackground: '#FFF', | ||
| primaryButtonText: 'red', |
Member
There was a problem hiding this comment.
why is createTheme used elsewhere but not here?
Contributor
Author
There was a problem hiding this comment.
so ThemeProvider supports partial theme, but Customizer actually doesn't. If we see places i use createTheme, it's for creating a full theme to pass to Customizer. (This is an improvement for ThemeProvider compared to Customizer)
dzearing
reviewed
Aug 11, 2020
| import { PartialTheme } from '@fluentui/react-theme-provider'; | ||
|
|
||
| export const FluentTheme: Theme = { | ||
| export const FluentTheme: PartialTheme = { |
Member
There was a problem hiding this comment.
we should really consider renaming this package to @fluentui/storybook-addons or something that doesn't seem like a fork of storybook.
Contributor
Author
There was a problem hiding this comment.
I agree, will take that as a follow-up!
dzearing
approved these changes
Aug 11, 2020
dzearing
reviewed
Aug 11, 2020
xugao
force-pushed
the
xgao/themeprovider-supportv7them
branch
from
55a1ba6 to
fdda8e8
Compare
Contributor
|
🎉 Handy links: |
Contributor
|
🎉 Handy links: |
Contributor
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
ITheme) toThemeProvidercomponentsprop inThemeto support passing component-level styles (similar to<Customizer scopeSettings={ Component: { styles: { // styles prop }}} />)ThemeProvidernow should be able to do everything theming-related thatCustomizercan doThemeProviderrespects global theme (fromloadThem) and theme withinCustomizerContext. All supported scenarios are covered by new screener tests inapps/vr-tests/src/stories/ThemeProvider.stories.tsx.Customizershimmer previously added inreact-next. We no longer need it for V8. For converged components (e.g. button),ThemeProviderwill be required for be functional. For all other V8 components (scoped to only contains FC changes, withoutscssconversion), currentCustomizeris sufficient.lib/compatinsidereact-theme-provider. We might need to havelib/nextlater based on work beyond v8.Upcoming
react-button: insidegetTokens, complete mappingThemetoTokenswhich are used by buttonsFocus areas to test
Screener tests inside
apps/vr-tests/src/stories/ThemeProvider.stories.tsx