makeStyles: fixing typings

[dzearing]

Had typings issues with passing in styles to makeStyles. Now it correctly resolves style sets or functions which resolve style sets.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 380259e:

Sandbox	Source
Fluent UI Button	Configuration
microsoft/fluentui: codesandbox-react-template	Configuration
microsoft/fluentui: codesandbox-react-next-template	Configuration
microsoft/fluentui: codesandbox-react-northstar-template	Configuration

[msft-github-bot]

Perf Analysis

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Dropdown	mount	2464	2454	5000	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
BaseButton	mount	850	857	5000
ButtonNext	mount	559	547	5000
Checkbox	mount	1540	1509	5000
CheckboxBase	mount	1264	1278	5000
CheckboxNext	mount	1591	1588	5000
ChoiceGroup	mount	4745	4796	5000
ChoiceGroupNext	mount	4833	4776	5000
ComboBox	mount	878	949	1000
CommandBar	mount	7323	7355	1000
ContextualMenu	mount	12752	12611	1000
DefaultButton	mount	1045	1049	5000
DetailsRow	mount	3317	3381	5000
DetailsRowFast	mount	3370	3345	5000
DetailsRowNoStyles	mount	3235	3155	5000
Dialog	mount	1399	1408	1000
DocumentCardTitle	mount	1749	1750	1000
Dropdown	mount	2464	2454	5000	Possible regression
FocusZone	mount	1732	1804	5000
IconButton	mount	1680	1643	5000
Label	mount	329	329	5000
Link	mount	449	431	5000
LinkNext	mount	464	473	5000
MenuButton	mount	1401	1378	5000
Nav	mount	3074	3070	1000
OverflowSet	mount	1366	1309	5000
OverflowSetNext	mount	988	1004	5000
Panel	mount	1434	1414	1000
Persona	mount	810	825	1000
Pivot	mount	1336	1363	1000
PivotNext	mount	1322	1352	1000
PrimaryButton	mount	1232	1205	5000
SearchBox	mount	1226	1208	5000
SearchBoxNext	mount	1262	1257	5000
Slider	mount	1435	1491	5000
SliderNext	mount	1880	1852	5000
SpinButton	mount	4835	4799	5000
SpinButtonNext	mount	4856	4850	5000
Spinner	mount	409	413	5000
SplitButton	mount	3012	2993	5000
Stack	mount	507	496	5000
StackWithIntrinsicChildren	mount	1803	1785	5000
StackWithTextChildren	mount	4722	4731	5000
TagPicker	mount	2615	2615	5000
TeachingBubble	mount	49698	49052	5000
TeachingBubbleNext	mount	49437	49015	5000
Text	mount	399	410	5000
TextField	mount	1335	1337	5000
ThemeProvider	mount	3717	3688	5000
ThemeProvider	virtual-rerender	434	448	5000
Toggle	mount	807	790	5000
ToggleNext	mount	807	807	5000
button	mount	116	107	5000

Perf Analysis (Fluent)

⚠️ 3 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
ButtonOverridesMissPerf.default	107	40	2.68:1	analysis
ButtonUseCssNestingPerf.default	55	45	1.22:1	analysis
ListCommonPerf.default	641	904	0.71:1	analysis

Perf comparison

Status	Scenario	Fluent TPI	Fabric TPI	Ratio	Iterations	Ticks
🎯	Avatar.Fluent	0.42	0.46	0.91:1	2000	833
🦄	Button.Fluent	0.1	0.18	0.56:1	5000	516
🔧	Checkbox.Fluent	0.61	0.34	1.79:1	1000	612
🎯	Dialog.Fluent	0.15	0.21	0.71:1	5000	752
🔧	Dropdown.Fluent	2.88	0.45	6.4:1	1000	2880
🔧	Icon.Fluent	0.14	0.05	2.8:1	5000	690
🦄	Image.Fluent	0.07	0.11	0.64:1	5000	352
🔧	Slider.Fluent	1.53	0.34	4.5:1	1000	1532
🔧	Text.Fluent	0.07	0.03	2.33:1	5000	343
🦄	Tooltip.Fluent	0.1	16.34	0.01:1	5000	506

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ButtonUseCssPerf.default	49	41	1.2:1
ButtonMinimalPerf.default	195	166	1.17:1
PortalMinimalPerf.default	137	118	1.16:1
AccordionMinimalPerf.default	159	139	1.14:1
RefMinimalPerf.default	211	190	1.11:1
Text.Fluent	343	309	1.11:1
SegmentMinimalPerf.default	333	304	1.1:1
FlexMinimalPerf.default	276	254	1.09:1
ReactionMinimalPerf.default	387	354	1.09:1
AttachmentMinimalPerf.default	151	140	1.08:1
ChatDuplicateMessagesPerf.default	420	388	1.08:1
ChatMinimalPerf.default	600	556	1.08:1
Icon.Fluent	690	638	1.08:1
ImageMinimalPerf.default	363	344	1.06:1
ButtonSlotsPerf.default	598	572	1.05:1
StatusMinimalPerf.default	656	627	1.05:1
TableMinimalPerf.default	375	356	1.05:1
TooltipMinimalPerf.default	776	742	1.05:1
Dialog.Fluent	752	716	1.05:1
AlertMinimalPerf.default	282	272	1.04:1
FormMinimalPerf.default	376	362	1.04:1
GridMinimalPerf.default	315	304	1.04:1
HeaderSlotsPerf.default	751	719	1.04:1
LabelMinimalPerf.default	388	373	1.04:1
PopupMinimalPerf.default	659	636	1.04:1
ProviderMergeThemesPerf.default	1946	1863	1.04:1
ProviderMinimalPerf.default	918	881	1.04:1
CardMinimalPerf.default	543	526	1.03:1
CarouselMinimalPerf.default	441	429	1.03:1
RadioGroupMinimalPerf.default	394	382	1.03:1
VideoMinimalPerf.default	581	566	1.03:1
Button.Fluent	516	500	1.03:1
Image.Fluent	352	341	1.03:1
Slider.Fluent	1532	1488	1.03:1
Tooltip.Fluent	506	493	1.03:1
AnimationMinimalPerf.default	383	377	1.02:1
AttachmentSlotsPerf.default	1109	1084	1.02:1
AvatarMinimalPerf.default	458	449	1.02:1
BoxMinimalPerf.default	326	321	1.02:1
CheckboxMinimalPerf.default	2746	2695	1.02:1
DialogMinimalPerf.default	740	724	1.02:1
DividerMinimalPerf.default	339	331	1.02:1
HeaderMinimalPerf.default	340	333	1.02:1
ItemLayoutMinimalPerf.default	1213	1192	1.02:1
MenuButtonMinimalPerf.default	1484	1451	1.02:1
SkeletonMinimalPerf.default	373	365	1.02:1
CustomToolbarPrototype.default	3663	3604	1.02:1
ToolbarMinimalPerf.default	902	887	1.02:1
Avatar.Fluent	833	815	1.02:1
Dropdown.Fluent	2880	2834	1.02:1
ChatWithPopoverPerf.default	453	450	1.01:1
EmbedMinimalPerf.default	1834	1811	1.01:1
MenuMinimalPerf.default	824	815	1.01:1
SliderMinimalPerf.default	1539	1518	1.01:1
SplitButtonMinimalPerf.default	3577	3556	1.01:1
TextMinimalPerf.default	316	314	1.01:1
DropdownMinimalPerf.default	2836	2830	1:1
InputMinimalPerf.default	1272	1269	1:1
ListMinimalPerf.default	453	451	1:1
LoaderMinimalPerf.default	710	713	1:1
TableManyItemsPerf.default	2079	2088	1:1
TreeWith60ListItems.default	208	207	1:1
Checkbox.Fluent	612	612	1:1
DropdownManyItemsPerf.default	732	738	0.99:1
IconMinimalPerf.default	615	622	0.99:1
TextAreaMinimalPerf.default	427	433	0.99:1
TreeMinimalPerf.default	838	845	0.99:1
LayoutMinimalPerf.default	362	370	0.98:1
ListWith60ListItems.default	926	1041	0.89:1
ListNestedPerf.default	571	845	0.68:1

[size-auditor]

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 56711ed

Possible causes

• The baseline build 56711ed is broken
• The Size Auditor run for the baseline build 56711ed was not triggered

Recommendations

• Please merge your branch for this Pull request with the latest master build and commit your changes once again

[msft-github-bot]

🎉@fluentui/react-theme-provider@v0.9.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Official NPM Release